From: Milan Broz <gmazyland@gmail.com>
To: Tom Eccles <tom.eccles@codethink.co.uk>, dm-crypt@saout.de
Cc: richardmaw@codethink.co.uk
Subject: Re: [dm-crypt] veritysetup forward error correction failure
Date: Thu, 18 Jul 2019 11:50:51 +0200 [thread overview]
Message-ID: <88b955e7-4eaa-a427-efc6-8de50e066758@gmail.com> (raw)
In-Reply-To: <82572fe1-20a7-64b5-4fa7-ba48f2265bcb@codethink.co.uk>
On 18/07/2019 11:10, Tom Eccles wrote:
> tomeccles@debian-kernel-builder:~$ uname -a
> Linux debian-kernel-builder 4.19.37-verity #6 SMP Wed Jul 17 11:47:38 BST
> 2019 x86_64 GNU/Linux
> tomeccles@debian-kernel-builder:~$ /usr/sbin/veritysetup --version
> veritysetup 2.1.0
>
> I can also reproduce the issue using veritysetup 2.2.0-rc1.
Thanks, the best would be to create an issue for cryptsetup project
https://gitlab.com/cryptsetup/cryptsetup/issues
(if it is a kernel bug we report it there later)
I will need some images (or a script to create them) to reproduce it though.
...
> Also, I tried adding some prints to veritysetup and the kernel, and on the
> face of it, the reed-solomon state (struct rs in veritysetup) seems the
> same.
AFAIK the kernel and our code was based on the same libfec code,
so I am quite interested to find out what is the difference here.
(It can take some time though, the userspace FEC image verification was
implemented by my student that already disappeared from the project :)
Thanks,
Milan
next prev parent reply other threads:[~2019-07-18 9:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 17:06 [dm-crypt] veritysetup forward error correction failure Tom Eccles
2019-07-17 18:00 ` Michael Kjörling
2019-07-17 19:49 ` Milan Broz
2019-07-18 9:10 ` Tom Eccles
2019-07-18 9:50 ` Milan Broz [this message]
2019-07-18 10:16 ` Tom Eccles
2019-07-18 11:41 ` Tom Eccles
2019-07-18 13:09 ` Milan Broz
2019-07-18 13:49 ` Tom Eccles
2019-07-18 13:59 ` Milan Broz
2019-07-18 14:01 ` Tom Eccles
2019-07-18 13:59 ` Tom Eccles
2019-07-19 7:38 ` Milan Broz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88b955e7-4eaa-a427-efc6-8de50e066758@gmail.com \
--to=gmazyland@gmail.com \
--cc=dm-crypt@saout.de \
--cc=richardmaw@codethink.co.uk \
--cc=tom.eccles@codethink.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox