DM-Crypt Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Milan Broz <gmazyland@gmail.com>
To: dm-crypt@saout.de
Subject: Re: [dm-crypt] Debian installer formatting LUKS2 devices by default?
Date: Fri, 23 Nov 2018 10:21:40 +0100	[thread overview]
Message-ID: <aa607562-adad-6aaa-1865-df1e43eea44a@gmail.com> (raw)
In-Reply-To: <20180731075342.GA25101@localhost.localdomain>

On 31/07/2018 09:53, Guilhem Moulin wrote:
> On Tue, 31 Jul 2018 at 06:00:30 +0000, Michael Kjörling wrote:
>> Obviously, there's nothing stopping whoever is installing the system
>> from dropping to a shell and setting up a container themselves, _even
>> if_ the installer _only_ does one version of on-disk format for LUKS.
>> So even if the installer _only_ does LUKS1, and the tools are built
>> with LUKS1 as default, it's not like that will _prevent_ people from
>> using the LUKS2 format if they really want to.
> 
> Sure, but now we can tell people wanting the installer to default to
> LUKS2 that it'll be the new upstream default in the future, and also
> give a rough ETA.  It's more efficient at appeasing them than replying
> they need to drop to a shell and manually format & unlock the volume :-)

Hi,

just an update to LUKS2 as a default:

I had to postpone a plan to release 2.1 with LUKS2 as default format
(to January/February 2019), and we will release very soon 2.0.6 with some fixes
of LUKS2 format validation that need to be in place before we switch the default.

And the reason (long story):

The LUKS2 format supports variable sizes of metadata and keyslot areas,
and documentation clearly defines the supported sizes.

Cryptsetup uses validation functions that should stop reading/writing invalid header
from disk (to hit not only coding mistakes but also intentional header corruptions).

Unfortunately, we kept too strict validation in code by mistake so only default
LUKS2 header size is recognized as a valid header now.

Currently only these default headers are present (both conversion and format
create only the default size), but in 2.1 we will provide an interface to
use different LUKS2 header sizes.
And these headers will be not usable with cryptsetup older than 2.0.6.

(Larger metadata areas are requested by some other projects that plan to use
LUKS2 header for storing own metadata used for unlocking LUKS2 devices.)

IOW the format is ok. We just messed up tests and validation code. Sorry about that.

Milan

  reply	other threads:[~2018-11-23  9:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-27  8:16 [dm-crypt] Debian installer formatting LUKS2 devices by default? Guilhem Moulin
2018-07-30 10:51 ` Milan Broz
2018-07-30 20:47   ` Guilhem Moulin
2018-07-31  6:00     ` Michael Kjörling
2018-07-31  7:53       ` Guilhem Moulin
2018-11-23  9:21         ` Milan Broz [this message]
2018-11-23 18:26           ` Guilhem Moulin
2018-11-23 18:46             ` Milan Broz
2019-01-25 13:54           ` Guilhem Moulin
2019-01-25 14:31             ` Milan Broz
2019-01-25 15:05               ` Guilhem Moulin
2019-02-05 15:29               ` Milan Broz
2018-07-31  8:56     ` Milan Broz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aa607562-adad-6aaa-1865-df1e43eea44a@gmail.com \
    --to=gmazyland@gmail.com \
    --cc=dm-crypt@saout.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox