From: Milan Broz <gmazyland@gmail.com>
To: "Jörg Kastning" <joerg.kastning@my-it-brain.de>
Cc: dm-crypt <dm-crypt@saout.de>
Subject: Re: [dm-crypt] Do you accept contributions to manpage via patch?
Date: Thu, 22 Oct 2020 11:56:20 +0200 [thread overview]
Message-ID: <b969b376-5704-e904-b933-2c4c9dc8c2d1@gmail.com> (raw)
In-Reply-To: <E0B96C1F-0DC7-46BB-8B8B-202B6964E2C3@my-it-brain.de>
On 22/10/2020 11:37, Jörg Kastning wrote:
>
>
> Am 22. Oktober 2020 10:36:07 MESZ schrieb Milan Broz <gmazyland@gmail.com>:
>> On 20/10/2020 21:53, Jörg Kastning wrote:
> [...]
>> But I have some notes before I can merge this.
>>
>> - the example section - one example how to use --type is perhaps ok,
>> but definitely
>> normal user should never use this option. I will remove it from example
>> 2 and 3.
>
> That's OK for me.
>
>> - example 5 needs a strong warning, this command make the LUKS device
>> unusable.
>> (but still detected as LUKS block device). It is really meant only for
>> data destruction
>> by removing all volume keys slots from header.
>
> Would you like to add the warning? If you like I can add it an resubmit the patch again.
Yes, if you can, please resubmit it.
(And the best would be if it is in git format-patch format, but I can reformat it later if you do not use git.)
Thanks
Milan
next prev parent reply other threads:[~2020-10-22 9:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-18 11:54 [dm-crypt] Do you accept contributions to manpage via patch? Jörg Kastning
2020-10-18 14:18 ` Milan Broz
2020-10-20 19:53 ` Jörg Kastning
2020-10-22 8:36 ` Milan Broz
2020-10-22 9:37 ` Jörg Kastning
2020-10-22 9:56 ` Milan Broz [this message]
2020-10-22 16:05 ` Jörg Kastning
2020-11-05 20:02 ` Jörg Kastning
2020-11-05 20:30 ` Milan Broz
2020-11-05 22:50 ` Arno Wagner
2020-11-12 12:39 ` Milan Broz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b969b376-5704-e904-b933-2c4c9dc8c2d1@gmail.com \
--to=gmazyland@gmail.com \
--cc=dm-crypt@saout.de \
--cc=joerg.kastning@my-it-brain.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox