public inbox for dm-crypt@saout.de
 help / color / mirror / Atom feed
From: Milan Broz <gmazyland@gmail.com>
To: Jordan Glover <Golden_Miller83@protonmail.ch>,
	Arno Wagner <arno@wagner.name>
Cc: "dm-crypt@saout.de" <dm-crypt@saout.de>
Subject: Re: [dm-crypt] Why is the chk_luks_keyslots tool not routinely included?
Date: Sun, 29 Mar 2020 16:09:56 +0200	[thread overview]
Message-ID: <d36d15f1-72ea-5df3-041b-8aa20d9b9cf0@gmail.com> (raw)
In-Reply-To: <sAFa3HRnMo-fU86koyorBn0p9157R3nI1B8qZI-tEuE5CkfOoNo0vHpDfi64DWv_3bThmnL3GjnsqmPwcoIOtcZL_UzjIza7MJ_-94NYFYA=@protonmail.ch>

On 29/03/2020 14:34, Jordan Glover wrote:
> On Sunday, March 29, 2020 10:20 AM, Arno Wagner <arno@wagner.name> wrote:
> 
>> I think that is a decision by the distros. I am certainly
>> willing to maintain it for the foreseeable future. It is
>> not really much effort.
> 
> The distros just do "make install" [1]. I think it's upstream who decides what this command does.
> 
> [1] https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/cryptsetup#n39

My plan was to include this check in repair command instead of adding additional binary.
(The code could remain basically the same.)

With LUKS2 we can store other data in binary keyslot area (depends on type), so it need a little
bit more work but it should not be a big problem.

Please report an issue for it, that helps to not forget about it.

Thanks,
Milan

  reply	other threads:[~2020-03-29 14:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-28 21:56 [dm-crypt] Why is the chk_luks_keyslots tool not routinely included? Robert Nichols
2020-03-29 10:20 ` Arno Wagner
2020-03-29 12:34   ` Jordan Glover
2020-03-29 14:09     ` Milan Broz [this message]
2020-03-29 17:19       ` Arno Wagner
2020-03-30  0:44       ` Robert Nichols

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d36d15f1-72ea-5df3-041b-8aa20d9b9cf0@gmail.com \
    --to=gmazyland@gmail.com \
    --cc=Golden_Miller83@protonmail.ch \
    --cc=arno@wagner.name \
    --cc=dm-crypt@saout.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox