From mboxrd@z Thu Jan 1 00:00:00 1970 From: Denis Semakin Subject: Re: dm table: add support for secure erase forwarding [was: Re: Adaptation secure erase forwarding for 4.1x kernels] Date: Tue, 27 Mar 2018 11:54:13 +0300 (MSK) Message-ID: <1182298863.106524.1522140853093.JavaMail.zimbra@omprussia.ru> References: <1496940834.549721.1520933025411.JavaMail.zimbra@omprussia.ru> <20180322151045.GA27598@redhat.com> <695931032.318989.1521816469739.JavaMail.zimbra@omprussia.ru> <20180323153844.GA4914@redhat.com> <1943462632.77431.1522073575389.JavaMail.zimbra@omprussia.ru> <20180326161132.GA21310@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180326161132.GA21310@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: snitzer Cc: dm-devel List-Id: dm-devel.ids Hi. >> Also, will it be usefully to add a "get...()" function for >> num_secure_erase_bios? Let's say get_num_secure_erase_bios(struct dm_target &ti); >> As it's done for num_discard_bios... > >Yes, it is required. I'll share a link to the final patch shortly, I've >still attributed the work to you. Thanks. I've already seen your final patch in device-mapper git repository and I have nothing to add from my side. > >BTW, please look into your text editor's settings: seems your patches >are using spaces rather than tabs (and you aren't even using 8 spaces?) It's not blame of editor (I prefer to use git), it's email client re-formats a message. Next time I'll do it via git send-mail. >Mike -- Best regards, Denis