From: Martin Wilck <mwilck@suse.de>
To: Benjamin Marzinski <bmarzins@redhat.com>,
Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Subject: Re: [PATCH 1/9] libmultipath: disable user_friendly_names for NetApp
Date: Tue, 26 Feb 2019 09:43:07 +0100 [thread overview]
Message-ID: <1201be739c3bd4a2ee7e2aa51a8cd02600714678.camel@suse.de> (raw)
In-Reply-To: <1550854692-19873-2-git-send-email-bmarzins@redhat.com>
On Fri, 2019-02-22 at 10:58 -0600, Benjamin Marzinski wrote:
> NetApp has tools that rely on devices using WWID names. To avoid
> breaking these, NetApp devices should continue to use WWID names,
> even
> if the default config is set to enable user_friendly_names. If users
> want to use user_friendly_names on NetApp devices, the must
> specifically
> override the device config.
>
> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
> ---
> libmultipath/hwtable.c | 1 +
> 1 file changed, 1 insertion(+)
Ok.
While looking at this, I realized that the multipath.conf(5) man page
doesn't mention the fact that user_friendly_names could be used in the
devices section of multipath.conf (which would be important for users
who want to override the NetApp default behavior).
Martin
>
> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> index d3a8d9b..8776411 100644
> --- a/libmultipath/hwtable.c
> +++ b/libmultipath/hwtable.c
> @@ -719,6 +719,7 @@ static struct hwentry default_hw[] = {
> .flush_on_last_del = FLUSH_ENABLED,
> .dev_loss = MAX_DEV_LOSS_TMO,
> .prio_name = PRIO_ONTAP,
> + .user_friendly_names = USER_FRIENDLY_NAMES_OFF,
> },
> {
> /*
next prev parent reply other threads:[~2019-02-26 8:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 16:58 [PATCH 0/9] Misc Multipath patches Benjamin Marzinski
2019-02-22 16:58 ` [PATCH 1/9] libmultipath: disable user_friendly_names for NetApp Benjamin Marzinski
2019-02-26 8:43 ` Martin Wilck [this message]
2019-02-22 16:58 ` [PATCH 2/9] libmultipath: handle existing paths in marginal_path enqueue Benjamin Marzinski
2019-02-22 16:58 ` [PATCH 3/9] multipathd: cleanup marginal paths checking timers Benjamin Marzinski
2019-02-22 16:58 ` [PATCH 4/9] libmultipath: fix marginal paths queueing errors Benjamin Marzinski
2019-02-22 16:58 ` [PATCH 5/9] libmultipath: fix marginal_paths nr_active check Benjamin Marzinski
2019-02-22 16:58 ` [PATCH 6/9] multipathd: Fix miscounting active paths Benjamin Marzinski
2019-02-26 9:15 ` Martin Wilck
2019-02-26 10:16 ` Martin Wilck
2019-02-22 16:58 ` [PATCH 7/9] multipathd: ignore failed wwid recheck Benjamin Marzinski
2019-02-26 9:42 ` Martin Wilck
2019-02-26 20:29 ` Benjamin Marzinski
2019-02-22 16:58 ` [PATCH 8/9] libmutipath: continue to use old state on PATH_PENDING Benjamin Marzinski
2019-02-26 10:12 ` Martin Wilck
2019-02-26 20:37 ` Benjamin Marzinski
2019-02-22 16:58 ` [PATCH 9/9] multipathd: use update_path_groups instead of reload_map Benjamin Marzinski
2019-02-26 10:47 ` Martin Wilck
2019-02-26 22:32 ` Benjamin Marzinski
2019-02-27 10:22 ` Martin Wilck
2019-02-26 10:50 ` [PATCH 0/9] Misc Multipath patches Martin Wilck
2019-02-26 15:10 ` Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1201be739c3bd4a2ee7e2aa51a8cd02600714678.camel@suse.de \
--to=mwilck@suse.de \
--cc=bmarzins@redhat.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox