Linux Device Mapper development
 help / color / mirror / Atom feed
From: Heinz Mauelshagen <heinzm@redhat.com>
To: device-mapper development <dm-devel@redhat.com>
Subject: Re: [PATCH 3/6] dm raid45 target: introduce message parser
Date: Mon, 22 Jun 2009 13:16:33 +0200	[thread overview]
Message-ID: <1245669393.7390.17.camel@o> (raw)
In-Reply-To: <68823474-5CFB-44EC-85F0-CE5FA8A5CF1D@redhat.com>

On Fri, 2009-06-19 at 12:35 -0500, Jonathan Brassow wrote:
> On Jun 15, 2009, at 12:21 PM, heinzm@redhat.com wrote:
> 
> > This patch adds the dm-message parser module.
> 
> Would it be ok to leave this out?  Would you be willing to implement  
> some simple parsing in 'raid_message' for now?

If arguments go the way, that this ain't buy us much code sharing with
other targets, sure.

More opinions from others ?

> 
> Maybe there are benefits that I am not seeing?

I did it to allow for argument parsing code to be sharable amongst
targets message methods aiming to simplify parsing in multiple targets.

Heinz

> 
>   brassow
> 
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel

      reply	other threads:[~2009-06-22 11:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-15 17:21 [PATCH 3/6] dm raid45 target: introduce message parser heinzm
2009-06-19 17:35 ` Jonathan Brassow
2009-06-22 11:16   ` Heinz Mauelshagen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1245669393.7390.17.camel@o \
    --to=heinzm@redhat.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox