Linux Device Mapper development
 help / color / mirror / Atom feed
From: Heinz Mauelshagen <heinzm@redhat.com>
To: device-mapper development <dm-devel@redhat.com>
Subject: Re: [PATCH dmraid 1/1] Ensure metadata dump of pdc metadata has the correct offset.
Date: Mon, 14 Dec 2009 15:35:00 +0100	[thread overview]
Message-ID: <1260801300.7677.39.camel@o> (raw)
In-Reply-To: <20091211033030.695580934@suse.de>


Applied to the sources repository.

Thanks,
Heinz

On Fri, 2009-12-11 at 14:27 +1100, NeilBrown wrote:
> plain text document attachment (pdc-metadata-dump-fix)
> a read_metadata function needds to set *offset so that file_metadata
> can create the correct xxx/dev-offset file.
> pdf_read_metadata does not set *offset.
> 
> This patch add the appropriate setting.
> 
> Signed-off-by: NeilBrown <neilb@suse.de>
> ---
>  1.0.0.rc16/lib/format/ataraid/pdc.c |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> --- dmraid.orig/1.0.0.rc16/lib/format/ataraid/pdc.c
> +++ dmraid/1.0.0.rc16/lib/format/ataraid/pdc.c
> @@ -202,8 +202,11 @@ pdc_read_metadata(struct lib_context *lc
>  							break;
>  
>  					/* Memorize main metadata sector. */
> -					} else if (!info->u32)
> +					} else if (!info->u32) {
>  						info->u32 = *s;
> +						*offset = sub ? di->sectors - *s : *s;
> +					}
> +
>  				}
>  			}
>  		}
> 
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel

      reply	other threads:[~2009-12-14 14:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-11  3:27 [PATCH dmraid 0/1] pdc metadata bug fix NeilBrown
2009-12-11  3:27 ` [PATCH dmraid 1/1] Ensure metadata dump of pdc metadata has the correct offset NeilBrown
2009-12-14 14:35   ` Heinz Mauelshagen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1260801300.7677.39.camel@o \
    --to=heinzm@redhat.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox