dm-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Peter Jones <pjones@redhat.com>
To: dm-devel@redhat.com
Cc: Peter Jones <pjones@redhat.com>
Subject: [PATCH] Fix missing dm_put()
Date: Mon, 18 Oct 2010 10:39:41 -0400	[thread overview]
Message-ID: <1287412781-26119-1-git-send-email-pjones@redhat.com> (raw)

The change to make UUID setable after map creation was missing one
dm_put() call; this patch adds it.
---
 drivers/md/dm-ioctl.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c
index 22c2e22..e2d106b 100644
--- a/drivers/md/dm-ioctl.c
+++ b/drivers/md/dm-ioctl.c
@@ -351,6 +351,7 @@ static struct mapped_device *dm_hash_rename(struct dm_ioctl *param,
 			DMWARN("Unable to change uuid of device, %s because "
 			       "uuid is already set to %s",
 			       param->name, hc->uuid);
+			dm_put(hd->md);
 			up_write(&_hash_lock);
 			kfree(new_data);
 			return ERR_PTR(-EINVAL);
-- 
1.7.2.2

                 reply	other threads:[~2010-10-18 14:39 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1287412781-26119-1-git-send-email-pjones@redhat.com \
    --to=pjones@redhat.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).