[PATCH] libmultipath: fix snprintf buffer overflows

[PATCH] libmultipath: fix snprintf buffer overflows

[Tim Harder]

[-- Attachment #1: Type: text/plain, Size: 134 bytes --]

Hi,

I've attached a patch against the latest git version of multipath-tools
to fix a couple snprintf buffer overflows. 

Thanks,
Tim

[-- Attachment #2: 0001-libmultipath-fix-snprintf-buffer-overflows.patch --]
[-- Type: text/plain, Size: 1469 bytes --]

From 2d51194853342ba24f3b76e9343b8467a8e55400 Mon Sep 17 00:00:00 2001
From: Tim Harder <radhermit@gentoo.org>
Date: Sun, 28 Nov 2010 12:37:08 -0800
Subject: [PATCH] libmultipath: fix snprintf buffer overflows

---
 libmultipath/prioritizers/datacore.c |    2 +-
 libmultipath/prioritizers/hds.c      |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/libmultipath/prioritizers/datacore.c b/libmultipath/prioritizers/datacore.c
index 6b7b202..2c16c6c 100644
--- a/libmultipath/prioritizers/datacore.c
+++ b/libmultipath/prioritizers/datacore.c
@@ -94,7 +94,7 @@ int datacore_prio (const char *dev, int sg_fd, char * args)
 	if ((io_hdr.info & SG_INFO_OK_MASK) != SG_INFO_OK)
 		return 0;
 
-	snprintf(vendor, 9, "%.8s\n", inqBuffp + 8);
+	snprintf(vendor, 8, "%.8s\n", inqBuffp + 8);
 	snprintf(product, 17, "%.16s", inqBuffp + 16);
 	snprintf(luname, 21, "%.19s", inqBuffp + 36);
 	snprintf(wwpn, 17, "%.16s", inqBuffp + 96);
diff --git a/libmultipath/prioritizers/hds.c b/libmultipath/prioritizers/hds.c
index 7b354b2..4789340 100644
--- a/libmultipath/prioritizers/hds.c
+++ b/libmultipath/prioritizers/hds.c
@@ -123,7 +123,7 @@ int hds_modular_prio (const char *dev, int fd)
 		return -1;
 	}
 
-	snprintf (vendor, 9, "%.8s", inqBuffp + 8);
+	snprintf (vendor, 8, "%.8s", inqBuffp + 8);
 	snprintf (product, 17, "%.16s", inqBuffp + 16);
 	snprintf (serial, 5, "%.4s", inqBuffp + 40);
 	snprintf (ldev, 5, "%.4s", inqBuffp + 44);
-- 
1.7.3.2


[-- Attachment #3: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] libmultipath: fix snprintf buffer overflows

[Christophe Varoqui]

On dim., 2010-11-28 at 13:12 -0800, Tim Harder wrote:
> Hi,
> 
> I've attached a patch against the latest git version of multipath-tools
> to fix a couple snprintf buffer overflows. 
> 

Thanks,
applied.