Linux Device Mapper development
 help / color / mirror / Atom feed
From: Christophe Varoqui <christophe.varoqui@gmail.com>
To: Hannes Reinecke <hare@suse.de>
Cc: device-mapper development <dm-devel@redhat.com>
Subject: Re: SUSE multipath-tools patch resync
Date: Wed, 25 May 2011 09:51:47 +0200	[thread overview]
Message-ID: <1306309907.2290.14.camel@lapoo.opensvc.com> (raw)
In-Reply-To: <4DD3DFC0.9050300@suse.de>

On mer., 2011-05-18 at 17:03 +0200, Hannes Reinecke wrote:
> git.kernel.org:/pub/scm/linux/kernel/git/hare/multipath-tools.git

I started the merge. I'll post comments along the reading. It seems
there won't be much : this patchset is clearly a must-have.

...

Shouldn't this one be reverted ? Seems the real thing is
10d68a92b2a0027d5468cf76656692f34f6dbc54


commit efc8ace4b335e752a7d28aca6040af0f9fe37530
Author: Hannes Reinecke <hare@suse.de>
Date:   Mon Feb 1 09:46:57 2010 +0100

    Add 'max_polling_interval' config variable
    
    We should be able to set the 'max_polling_interval' variable
    manually. Especially systems requiring precise failover timing
    will want to disable the automatic polling interval increase.
    
    Signed-off-by: Hannes Reinecke <hare@suse.de>

diff --git a/multipathd/main.c b/multipathd/main.c
index 7659bb2..6867f23 100644
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -1096,9 +1096,9 @@ check_path (struct vectors * vecs, struct path *
pp)
                         * max at conf->max_checkint
                         */
                        if (pp->checkint < (conf->max_checkint / 2))
-                               pp->checkint = 2 * pp->checkint;
+                           pp->checkint = 2 * pp->checkint;
                        else
-                               pp->checkint = conf->max_checkint;
+                           pp->checkint = conf->max_checkint;
 
                        pp->tick = pp->checkint;
                        condlog(4, "%s: delay next check %is",

  parent reply	other threads:[~2011-05-25  7:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-18 15:03 SUSE multipath-tools patch resync Hannes Reinecke
2011-05-20  6:26 ` Christophe Varoqui
2011-05-25  7:51 ` Christophe Varoqui [this message]
2011-05-25  9:08   ` Hannes Reinecke
2011-05-25 11:14     ` Christophe Varoqui
2011-05-25 12:10       ` Christophe Varoqui
2011-05-25 12:22         ` Christophe Varoqui
2011-05-25 12:45           ` Hannes Reinecke
2011-05-25 21:29           ` Christophe Varoqui
2011-05-26  6:28             ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1306309907.2290.14.camel@lapoo.opensvc.com \
    --to=christophe.varoqui@gmail.com \
    --cc=christophe.varoqui@opensvc.com \
    --cc=dm-devel@redhat.com \
    --cc=hare@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox