dm-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Christophe Varoqui <christophe.varoqui@gmail.com>
To: Benjamin Marzinski <bmarzins@redhat.com>
Cc: device-mapper development <dm-devel@redhat.com>
Subject: Re: [PATCH] multipath: don't print so many add map messages
Date: Sat, 12 Nov 2011 11:17:35 +0100	[thread overview]
Message-ID: <1321093055.14506.6.camel@lapoo.opensvc.com> (raw)
In-Reply-To: <20111112051249.GF24133@ether.msp.redhat.com>

On ven., 2011-11-11 at 23:12 -0600, Benjamin Marzinski wrote:
> Whenever a dm device gets a change uevent, multipathd prints an add map
> message.  This can get confusing for users, so change that message to
> not print at the default log level, and add a new message that only
> prints if multipathd will actually try to add a map
> 
Applied.

> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
> ---
>  multipathd/main.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> Index: multipath-tools-111111/multipathd/main.c
> ===================================================================
> --- multipath-tools-111111.orig/multipathd/main.c
> +++ multipath-tools-111111/multipathd/main.c
> @@ -232,7 +232,7 @@ uev_add_map (struct uevent * uev, struct
>  	char *alias;
>  	int major = -1, minor = -1, rc;
>  
> -	condlog(2, "%s: add map (uevent)", uev->kernel);
> +	condlog(3, "%s: add map (uevent)", uev->kernel);
>  	alias = uevent_get_dm_name(uev);
>  	if (!alias) {
>  		condlog(3, "%s: No DM_NAME in uevent", uev->kernel);
> @@ -280,6 +280,7 @@ ev_add_map (char * dev, char * alias, st
>  		}
>  		return 0;
>  	}
> +	condlog(2, "%s: adding map", alias);
>  
>  	/*
>  	 * now we can register the map

      reply	other threads:[~2011-11-12 10:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-12  5:12 [PATCH] multipath: don't print so many add map messages Benjamin Marzinski
2011-11-12 10:17 ` Christophe Varoqui [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1321093055.14506.6.camel@lapoo.opensvc.com \
    --to=christophe.varoqui@gmail.com \
    --cc=bmarzins@redhat.com \
    --cc=christophe.varoqui@opensvc.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).