* [PATCH] multipath: Set the default max_fds to the system max
@ 2011-11-12 5:10 Benjamin Marzinski
2011-11-12 10:17 ` Christophe Varoqui
0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Marzinski @ 2011-11-12 5:10 UTC (permalink / raw)
To: device-mapper development; +Cc: Christophe Varoqui
Since many people don't realize that they need to set max_fds until they run
out of file descriptors, default to the system max.
Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
---
libmultipath/config.c | 2 +-
libmultipath/dict.c | 2 +-
libmultipath/dict.h | 1 +
3 files changed, 3 insertions(+), 2 deletions(-)
Index: multipath-tools-111111/libmultipath/config.c
===================================================================
--- multipath-tools-111111.orig/libmultipath/config.c
+++ multipath-tools-111111/libmultipath/config.c
@@ -493,7 +493,7 @@ load_config (char * file)
conf->dev_type = DEV_NONE;
conf->minio = DEFAULT_MINIO;
conf->minio_rq = DEFAULT_MINIO_RQ;
- conf->max_fds = 0;
+ get_sys_max_fds(&conf->max_fds);
conf->bindings_file = set_default(DEFAULT_BINDINGS_FILE);
conf->bindings_read_only = 0;
conf->multipath_dir = set_default(DEFAULT_MULTIPATHDIR);
Index: multipath-tools-111111/libmultipath/dict.c
===================================================================
--- multipath-tools-111111.orig/libmultipath/dict.c
+++ multipath-tools-111111/libmultipath/dict.c
@@ -255,7 +255,7 @@ def_minio_rq_handler(vector strvec)
return 0;
}
-static int
+int
get_sys_max_fds(int *max_fds)
{
FILE *file;
Index: multipath-tools-111111/libmultipath/dict.h
===================================================================
--- multipath-tools-111111.orig/libmultipath/dict.h
+++ multipath-tools-111111/libmultipath/dict.h
@@ -6,5 +6,6 @@
#endif
void init_keywords(void);
+int get_sys_max_fds(int *);
#endif /* _DICT_H */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] multipath: Set the default max_fds to the system max
2011-11-12 5:10 [PATCH] multipath: Set the default max_fds to the system max Benjamin Marzinski
@ 2011-11-12 10:17 ` Christophe Varoqui
0 siblings, 0 replies; 2+ messages in thread
From: Christophe Varoqui @ 2011-11-12 10:17 UTC (permalink / raw)
To: Benjamin Marzinski; +Cc: device-mapper development
On ven., 2011-11-11 at 23:10 -0600, Benjamin Marzinski wrote:
> Since many people don't realize that they need to set max_fds until they run
> out of file descriptors, default to the system max.
>
Applied
> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
> ---
> libmultipath/config.c | 2 +-
> libmultipath/dict.c | 2 +-
> libmultipath/dict.h | 1 +
> 3 files changed, 3 insertions(+), 2 deletions(-)
>
> Index: multipath-tools-111111/libmultipath/config.c
> ===================================================================
> --- multipath-tools-111111.orig/libmultipath/config.c
> +++ multipath-tools-111111/libmultipath/config.c
> @@ -493,7 +493,7 @@ load_config (char * file)
> conf->dev_type = DEV_NONE;
> conf->minio = DEFAULT_MINIO;
> conf->minio_rq = DEFAULT_MINIO_RQ;
> - conf->max_fds = 0;
> + get_sys_max_fds(&conf->max_fds);
> conf->bindings_file = set_default(DEFAULT_BINDINGS_FILE);
> conf->bindings_read_only = 0;
> conf->multipath_dir = set_default(DEFAULT_MULTIPATHDIR);
> Index: multipath-tools-111111/libmultipath/dict.c
> ===================================================================
> --- multipath-tools-111111.orig/libmultipath/dict.c
> +++ multipath-tools-111111/libmultipath/dict.c
> @@ -255,7 +255,7 @@ def_minio_rq_handler(vector strvec)
> return 0;
> }
>
> -static int
> +int
> get_sys_max_fds(int *max_fds)
> {
> FILE *file;
> Index: multipath-tools-111111/libmultipath/dict.h
> ===================================================================
> --- multipath-tools-111111.orig/libmultipath/dict.h
> +++ multipath-tools-111111/libmultipath/dict.h
> @@ -6,5 +6,6 @@
> #endif
>
> void init_keywords(void);
> +int get_sys_max_fds(int *);
>
> #endif /* _DICT_H */
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-12 10:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-12 5:10 [PATCH] multipath: Set the default max_fds to the system max Benjamin Marzinski
2011-11-12 10:17 ` Christophe Varoqui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).