dm-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Christophe Varoqui <christophe.varoqui@gmail.com>
To: Benjamin Marzinski <bmarzins@redhat.com>
Cc: device-mapper development <dm-devel@redhat.com>,
	Christophe Varoqui <christophe.varoqui@gmail.com>
Subject: Re: [PATCH 0/2] multipath: compile cleanup
Date: Fri, 25 May 2012 07:20:53 +0200	[thread overview]
Message-ID: <1337923253.757.0.camel@lapoo.opensvc.com> (raw)
In-Reply-To: <1337921863-26482-1-git-send-email-bmarzins@redhat.com>

On jeu., 2012-05-24 at 23:57 -0500, Benjamin Marzinski wrote:
> When the multipath code is compiled with the standard redhat rpm cflags,
> there are a number of warnings that get issued, some about real problems.
> 
> These patches switch multipath to use those cflags, and then clean up
> warnings. If people want upstream to continue using the existing cflags,
> I don't particularly mind.  I really included the first patch to make sure
> people can see the warnings that the second patch corrects.
> 
> Also, some of the warnings are for actual errors, and how to fix them is
> obvious.  Others won't actually cause problems, and if people object to
> the changes I made to make them go away, I'm happy to fix them differently. 
> 
Merged.

Thanks.

> Benjamin Marzinski (2):
>   multipath: Build with standard rpm cflags
>   multipath: Fix warnings from stricter compile options.
> 
>  Makefile.inc                     |    6 +++++-
>  libmpathpersist/mpath_persist.c  |   10 +++++++---
>  libmpathpersist/mpath_pr_ioctl.c |    9 +++++++++
>  libmultipath/alias.c             |    8 ++++++--
>  mpathpersist/main.c              |    2 --
>  multipathd/main.c                |   24 +++++++++++++++++++-----
>  6 files changed, 46 insertions(+), 13 deletions(-)
> 

      parent reply	other threads:[~2012-05-25  5:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-25  4:57 [PATCH 0/2] multipath: compile cleanup Benjamin Marzinski
2012-05-25  4:57 ` [PATCH 1/2] multipath: Build with standard rpm cflags Benjamin Marzinski
2012-05-25  4:57 ` [PATCH 2/2] multipath: Fix warnings from stricter compile options Benjamin Marzinski
2012-05-25  5:20 ` Christophe Varoqui [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337923253.757.0.camel@lapoo.opensvc.com \
    --to=christophe.varoqui@gmail.com \
    --cc=bmarzins@redhat.com \
    --cc=christophe.varoqui@opensvc.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).