Re: [dm-devel] [PATCH v3] multipathd: handle fpin events

[Martin Wilck <martin.wilck@suse.com>]

On Thu, 2022-02-10 at 17:07 +0100, Martin Wilck wrote:
> On Wed, 2022-02-09 at 19:28 -0800, Muneendra Kumar wrote:
> > This patch incorporates the functionality to handle
> > FPIN ELS events present as part of FCTransport daemon
> > (available in EPEL8) into the multipathd. This helps us to
> > reduce the response time to react and take the necessary actions
> > on receiving the FPIN events.
> > 
> > This patch currently support FPIN-Li Events.
> > 
> > It adds a new thread to listen for ELS frames from driver and on
> > receiving the frame payload, push the payload to a list and notify
> > the
> > fpin_els_li_consumer thread to process it.Once consumer thread is
> > notified, it returns to listen for more ELS frames from driver.
> > 
> > The consumer thread process the ELS frames and moves the devices
> > paths
> > which are affected due to link integrity to marginal path groups.
> > This also sets the associated portstate to marginal.
> > The paths which are set to marginal path group will be unset
> > on receiving the RSCN events
> > 
> > Signed-off-by: Muneendra Kumar <muneendra.kumar@broadcom.com>
> > Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
> > ---
> 
> Reviewed-by: Martin Wilck <mwilck@suse.com>
> 
> Thanks!
> 
> Martin
> 

The CI found a minor issue on 32bit, which I'll fixup myself as shown
below.

Martin

diff --git a/multipathd/fpin_handlers.c b/multipathd/fpin_handlers.c
index 2a94024..a5e9477 100644
--- a/multipathd/fpin_handlers.c
+++ b/multipathd/fpin_handlers.c
@@ -287,7 +287,7 @@ fpin_parse_li_els_setpath_marginal(uint16_t host_num, struct fc_tlv_desc *tlv,
 		wwpn = be64_to_cpu(li_desc->pname_list[iter]);
 		ret = fpin_chk_wwn_setpath_marginal(host_num, vecs, wwpn);
 		if (ret < 0)
-			condlog(2, "failed to set the path marginal associated with wwpn: 0x%lx\n", wwpn);
+			condlog(2, "failed to set the path marginal associated with wwpn: 0x%" PRIx64 "\n", wwpn);
 
 		count++;
 	}


--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel