From: Mike Snitzer <snitzer@redhat.com>
To: James Bottomley <jbottomley@parallels.com>
Cc: dm-devel@redhat.com, linux-scsi@vger.kernel.org
Subject: [RESEND PATCH 3/3] dm mpath: add ability to disable partition creation
Date: Tue, 26 Jun 2012 14:32:05 -0400 [thread overview]
Message-ID: <1340735525-21083-4-git-send-email-snitzer@redhat.com> (raw)
In-Reply-To: <1340735525-21083-1-git-send-email-snitzer@redhat.com>
From: Hannes Reinecke <hare@suse.de>
When multipath devices are being used as disks for VM Guests any
partition scanning / setup should be done within the VM Guest, not from
host. So we need to a mechanism to switch off partition scanning and
creation via kpartx.
The new 'no_partitions' feature serves as a notifier to kpartx to _not_
create partitions on these multipath devices.
Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Reviewed-by: Chandra Seetharaman <sekharan@us.ibm.com>
---
drivers/md/dm-mpath.c | 13 +++++++++++--
1 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
index 4dd3f59..115ad9e 100644
--- a/drivers/md/dm-mpath.c
+++ b/drivers/md/dm-mpath.c
@@ -86,6 +86,7 @@ struct multipath {
unsigned queue_if_no_path:1; /* Queue I/O if last path fails? */
unsigned saved_queue_if_no_path:1; /* Saved state during suspension */
unsigned use_default_hw_handler:1; /* Use attached device handler */
+ unsigned no_partitions:1; /* Avoid partition scanning */
unsigned pg_init_retries; /* Number of times to retry pg_init */
unsigned pg_init_count; /* Number of times pg_init called */
@@ -772,7 +773,7 @@ static int parse_features(struct dm_arg_set *as, struct multipath *m)
const char *arg_name;
static struct dm_arg _args[] = {
- {0, 6, "invalid number of feature args"},
+ {0, 7, "invalid number of feature args"},
{1, 50, "pg_init_retries must be between 1 and 50"},
{0, 60000, "pg_init_delay_msecs must be between 0 and 60000"},
};
@@ -798,6 +799,11 @@ static int parse_features(struct dm_arg_set *as, struct multipath *m)
continue;
}
+ if (!strcasecmp(arg_name, "no_partitions")) {
+ m->no_partitions = 1;
+ continue;
+ }
+
if (!strcasecmp(arg_name, "pg_init_retries") &&
(argc >= 1)) {
r = dm_read_arg(_args + 1, as, &m->pg_init_retries, &ti->error);
@@ -1382,7 +1388,8 @@ static int multipath_status(struct dm_target *ti, status_type_t type,
DMEMIT("%u ", m->queue_if_no_path +
(m->pg_init_retries > 0) * 2 +
(m->pg_init_delay_msecs != DM_PG_INIT_DELAY_DEFAULT) * 2 +
- m->use_default_hw_handler);
+ m->use_default_hw_handler +
+ m->no_partitions);
if (m->queue_if_no_path)
DMEMIT("queue_if_no_path ");
if (m->pg_init_retries)
@@ -1391,6 +1398,8 @@ static int multipath_status(struct dm_target *ti, status_type_t type,
DMEMIT("pg_init_delay_msecs %u ", m->pg_init_delay_msecs);
if (m->use_default_hw_handler)
DMEMIT("default_hw_handler ");
+ if (m->no_partitions)
+ DMEMIT("no_partitions ");
}
if (!m->hw_handler_name || type == STATUSTYPE_INFO)
--
1.7.4.4
next prev parent reply other threads:[~2012-06-26 18:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 18:32 [RESEND PATCH 0/3] multipath features for 3.6 Mike Snitzer
2012-06-26 18:32 ` [RESEND PATCH 1/3] scsi_dh: add scsi_dh_attached_handler_name Mike Snitzer
2012-07-02 21:07 ` Mike Snitzer
2012-06-26 18:32 ` [RESEND PATCH 2/3] dm mpath: add 'default_hw_handler' feature Mike Snitzer
2012-06-27 6:16 ` [dm-devel] " Hannes Reinecke
2012-07-11 10:27 ` Alasdair G Kergon
2012-07-11 13:20 ` Mike Snitzer
2012-06-26 18:32 ` Mike Snitzer [this message]
2012-07-11 15:18 ` [dm-devel] [RESEND PATCH 3/3] dm mpath: add ability to disable partition creation Alasdair G Kergon
2012-07-25 12:02 ` Hannes Reinecke
2012-07-26 17:03 ` Benjamin Marzinski
2012-07-27 14:00 ` [dm-devel] " Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340735525-21083-4-git-send-email-snitzer@redhat.com \
--to=snitzer@redhat.com \
--cc=dm-devel@redhat.com \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).