dm-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Christophe Varoqui <christophe.varoqui@gmail.com>
To: Benjamin Marzinski <bmarzins@redhat.com>
Cc: device-mapper development <dm-devel@redhat.com>,
	Christophe Varoqui <christophe.varoqui@gmail.com>
Subject: Re: [PATCH][RESEND] multipath: fix cciss device names
Date: Fri, 17 Aug 2012 21:57:24 +0200	[thread overview]
Message-ID: <1345233444.12286.0.camel@lapoo.opensvc.com> (raw)
In-Reply-To: <20120727205718.GL5299@ether.msp.redhat.com>

On ven., 2012-07-27 at 15:57 -0500, Benjamin Marzinski wrote:
> When we're looking for cciss devices in sysfs, they have a "!" not a "/".
> If users run multipath on a cciss device using it's devnode name,
> /dev/cciss/cXdY, multipath should convert that to the sysfs name.
> 
Applied.

Thanks.

> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
> ---
>  multipath/main.c |   12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> Index: multipath-tools-120518/multipath/main.c
> ===================================================================
> --- multipath-tools-120518.orig/multipath/main.c
> +++ multipath-tools-120518/multipath/main.c
> @@ -409,6 +409,16 @@ get_dev_type(char *dev) {
>  		return DEV_DEVMAP;
>  }
>  
> +static void
> +convert_dev(char *dev)
> +{
> +	char *ptr = strstr(dev, "cciss/");
> +	if (ptr) {
> +		ptr += 5;
> +		*ptr = '!';
> +	}
> +}
> +
>  int
>  main (int argc, char *argv[])
>  {
> @@ -514,6 +524,8 @@ main (int argc, char *argv[])
>  
>  		strncpy(conf->dev, argv[optind], FILE_NAME_SIZE);
>  		conf->dev_type = get_dev_type(conf->dev);
> +		if (conf->dev_type == DEV_DEVNODE)
> +			convert_dev(conf->dev);
>  	}
>  	conf->daemon = 0;
>  

      reply	other threads:[~2012-08-17 19:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-27 20:57 [PATCH][RESEND] multipath: fix cciss device names Benjamin Marzinski
2012-08-17 19:57 ` Christophe Varoqui [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1345233444.12286.0.camel@lapoo.opensvc.com \
    --to=christophe.varoqui@gmail.com \
    --cc=bmarzins@redhat.com \
    --cc=christophe.varoqui@opensvc.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).