From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH 2/2] dm: stay in blk_queue_bypass until queue becomes initialized Date: Mon, 29 Oct 2012 17:45:15 +0100 Message-ID: <1351529115.24721.40.camel@twins> References: <50890937.7010809@ce.jp.nec.com> <20121026202105.GF24687@redhat.com> <508E572C.6000707@ce.jp.nec.com> <20121029163845.GB7709@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: In-Reply-To: <20121029163845.GB7709@redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Vivek Goyal Cc: Jun'ichi Nomura , "linux-kernel@vger.kernel.org" , device-mapper development , Tejun Heo , Jens Axboe , Alasdair G Kergon , "Paul E. McKenney" List-Id: dm-devel.ids On Mon, 2012-10-29 at 12:38 -0400, Vivek Goyal wrote: > Ok, so the question is what's wrong with calling synchronize_rcu() inside > a mutex with CONFIG_PREEMPT=y. I don't know. Ccing paul mckenney and > peterz. int blkcg_activate_policy(struct request_queue *q, { ... preloaded = !radix_tree_preload(GFP_KERNEL); blk_queue_bypass_start(q); where: int radix_tree_preload(gfp_t gfp_mask) { struct radix_tree_preload *rtp; struct radix_tree_node *node; int ret = -ENOMEM; preempt_disable(); Seems obvious why it explodes..