From: Mike Snitzer <snitzer@redhat.com>
To: Frank Mayhar <fmayhar@google.com>, Mikulas Patocka <mpatocka@redhat.com>
Cc: dm-devel@redhat.com
Subject: [PATCH 2/7] dm: add reserved_rq_based_ios module parameter
Date: Thu, 12 Sep 2013 18:24:53 -0400 [thread overview]
Message-ID: <1379024698-10487-3-git-send-email-snitzer@redhat.com> (raw)
In-Reply-To: <1379024698-10487-1-git-send-email-snitzer@redhat.com>
Allow user to change the number of IOs that are reserved by
request-based DM's mempools by writing to this file:
/sys/module/dm_mod/parameters/reserved_rq_based_ios
The default value is RESERVED_REQUEST_BASED_IOS (256).
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
---
drivers/md/dm.c | 49 ++++++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 48 insertions(+), 1 deletion(-)
diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index 47bac14..8553d03 100644
--- a/drivers/md/dm.c
+++ b/drivers/md/dm.c
@@ -216,6 +216,38 @@ struct dm_md_mempools {
static struct kmem_cache *_io_cache;
static struct kmem_cache *_rq_tio_cache;
+/*
+ * Request-based DM's mempools' reserved IOs set by the user
+ */
+static unsigned reserved_rq_based_ios;
+
+/*
+ * A copy of reserved_rq_based_ios because it can change anytime.
+ * If values disagree, the user has changed reserved_rq_based_ios.
+ */
+static unsigned reserved_rq_based_ios_latch;
+
+/*
+ * This mutex protects reserved_rq_based_ios_latch.
+ */
+static DEFINE_MUTEX(dm_mempools_lock);
+
+static void __reserved_request_based_ios_refresh(void)
+{
+ BUG_ON(!mutex_is_locked(&dm_mempools_lock));
+
+ reserved_rq_based_ios_latch = ACCESS_ONCE(reserved_rq_based_ios);
+
+ /*
+ * If the user uses "0", it means default. Modify
+ * reserved_rq_based_ios to report the default to the user.
+ */
+ if (!reserved_rq_based_ios_latch) {
+ (void)cmpxchg(&reserved_rq_based_ios, 0, RESERVED_REQUEST_BASED_IOS);
+ reserved_rq_based_ios_latch = reserved_rq_based_ios;
+ }
+}
+
static int __init local_init(void)
{
int r = -ENOMEM;
@@ -241,6 +273,10 @@ static int __init local_init(void)
if (!_major)
_major = r;
+ mutex_lock(&dm_mempools_lock);
+ __reserved_request_based_ios_refresh();
+ mutex_unlock(&dm_mempools_lock);
+
return 0;
out_uevent_exit:
@@ -2867,7 +2903,14 @@ struct dm_md_mempools *dm_alloc_md_mempools(unsigned type, unsigned integrity, u
front_pad = roundup(per_bio_data_size, __alignof__(struct dm_target_io)) + offsetof(struct dm_target_io, clone);
} else if (type == DM_TYPE_REQUEST_BASED) {
cachep = _rq_tio_cache;
- pool_size = RESERVED_REQUEST_BASED_IOS;
+
+ mutex_lock(&dm_mempools_lock);
+ /* Check if reserved_rq_based_ios changed. */
+ if (reserved_rq_based_ios != reserved_rq_based_ios_latch)
+ __reserved_request_based_ios_refresh();
+ pool_size = reserved_rq_based_ios_latch;
+ mutex_unlock(&dm_mempools_lock);
+
front_pad = offsetof(struct dm_rq_clone_bio_info, clone);
/* per_bio_data_size is not used. See __bind_mempools(). */
WARN_ON(per_bio_data_size != 0);
@@ -2925,6 +2968,10 @@ module_exit(dm_exit);
module_param(major, uint, 0);
MODULE_PARM_DESC(major, "The major number of the device mapper");
+
+module_param(reserved_rq_based_ios, uint, S_IRUGO | S_IWUSR);
+MODULE_PARM_DESC(reserved_rq_based_ios, "Reserved IOs in request-based mempools");
+
MODULE_DESCRIPTION(DM_NAME " driver");
MODULE_AUTHOR("Joe Thornber <dm-devel@redhat.com>");
MODULE_LICENSE("GPL");
--
1.8.1.4
next prev parent reply other threads:[~2013-09-12 22:24 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1376070533.26057.244.camel@bobble.lax.corp.google.com>
2013-08-17 12:30 ` [dm-devel] [PATCH] dm: Make MIN_IOS, et al, tunable via sysctl Alasdair G Kergon
2013-08-19 13:40 ` Mike Snitzer
2013-08-19 15:04 ` Frank Mayhar
2013-08-19 14:00 ` Mike Snitzer
2013-08-19 17:54 ` [dm-devel] " Frank Mayhar
2013-08-19 18:15 ` Mike Snitzer
2013-08-20 21:44 ` [dm-devel] " Mikulas Patocka
2013-08-20 21:52 ` Frank Mayhar
2013-08-20 21:41 ` Mikulas Patocka
2013-08-20 21:22 ` [dm-devel] [PATCH] " Mikulas Patocka
2013-08-20 21:28 ` Frank Mayhar
2013-08-20 21:47 ` Mikulas Patocka
2013-08-20 21:57 ` Frank Mayhar
2013-08-20 22:24 ` Mike Snitzer
2013-08-20 22:52 ` Mikulas Patocka
2013-08-20 23:14 ` Frank Mayhar
2013-08-22 17:26 ` Frank Mayhar
2013-08-26 14:28 ` Mikulas Patocka
2013-09-12 22:24 ` [PATCH 0/7] dm: allow mempool and bioset reserves to be tuned Mike Snitzer
2013-09-12 22:24 ` [PATCH 1/7] dm: lower bio-based mempool reservation Mike Snitzer
2013-09-12 22:40 ` Mikulas Patocka
2013-09-12 22:24 ` Mike Snitzer [this message]
2013-09-12 22:45 ` [PATCH 2/7] dm: add reserved_rq_based_ios module parameter Mikulas Patocka
2013-09-12 23:15 ` Mike Snitzer
2013-09-12 23:27 ` Mikulas Patocka
2013-09-12 23:32 ` Mike Snitzer
2013-09-12 22:24 ` [PATCH 3/7] dm: add reserved_bio_based_ios " Mike Snitzer
2013-09-12 22:47 ` Mikulas Patocka
2013-09-12 23:11 ` Mike Snitzer
2013-09-12 23:17 ` Mikulas Patocka
2013-09-18 15:17 ` Frank Mayhar
2013-09-12 22:24 ` [PATCH 4/7] dm io: use dm_get_reserved_bio_based_ios to size reserves Mike Snitzer
2013-09-12 22:48 ` Mikulas Patocka
2013-09-12 22:24 ` [PATCH 5/7] dm mpath: use dm_get_reserved_rq_based_ios to size mempool Mike Snitzer
2013-09-12 22:48 ` Mikulas Patocka
2013-09-12 22:24 ` [PATCH 6/7] dm: track the maximum number of bios in a cloned request Mike Snitzer
2013-09-12 22:55 ` Mikulas Patocka
2013-09-12 23:09 ` Mike Snitzer
2013-09-12 22:24 ` [PATCH 7/7] dm: optimize clone_rq() when track_peak_rq_based_ios is disabled Mike Snitzer
2013-09-12 23:00 ` Mikulas Patocka
2013-09-12 23:06 ` Mike Snitzer
2013-09-12 23:30 ` Mikulas Patocka
2013-09-12 23:53 ` Mike Snitzer
2013-09-13 4:46 ` Jun'ichi Nomura
2013-09-13 13:04 ` Mike Snitzer
2013-09-13 14:34 ` Mikulas Patocka
2013-09-13 18:59 ` [PATCH v2 0/3] dm: allow mempool and bioset reserves to be tuned Mike Snitzer
2013-09-13 18:59 ` [PATCH v2 1/3] dm: lower bio-based mempool reservation Mike Snitzer
2013-09-13 18:59 ` [PATCH v2 2/3] dm: add reserved_rq_based_ios module parameter Mike Snitzer
2013-09-13 18:59 ` [PATCH v2 3/3] dm: add reserved_bio_based_ios " Mike Snitzer
2013-09-13 19:22 ` [PATCH v2 0/3] dm: allow mempool and bioset reserves to be tuned Mike Snitzer
2013-09-13 20:30 ` Mike Snitzer
2013-09-13 21:08 ` [PATCH v3 " Mike Snitzer
2013-09-13 21:08 ` [PATCH v3 1/3] dm: lower bio-based mempool reservation Mike Snitzer
2013-09-13 21:08 ` [PATCH v3 2/3] dm: add reserved_rq_based_ios module parameter Mike Snitzer
2013-09-13 21:08 ` [PATCH v3 3/3] dm: add reserved_bio_based_ios " Mike Snitzer
2013-09-18 15:10 ` [PATCH v3 0/3] dm: allow mempool and bioset reserves to be tuned Frank Mayhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379024698-10487-3-git-send-email-snitzer@redhat.com \
--to=snitzer@redhat.com \
--cc=dm-devel@redhat.com \
--cc=fmayhar@google.com \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).