From: Mike Snitzer <snitzer@redhat.com>
To: Frank Mayhar <fmayhar@google.com>, Mikulas Patocka <mpatocka@redhat.com>
Cc: dm-devel@redhat.com
Subject: [PATCH 4/7] dm io: use dm_get_reserved_bio_based_ios to size reserves
Date: Thu, 12 Sep 2013 18:24:55 -0400 [thread overview]
Message-ID: <1379024698-10487-5-git-send-email-snitzer@redhat.com> (raw)
In-Reply-To: <1379024698-10487-1-git-send-email-snitzer@redhat.com>
Switch dm-io over to sizing its mempool and bioset using DM core's
configurable 'reserved_bio_based_ios'.
Export dm_get_reserved_bio_based_ios() for use by DM targets and core
code.
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
---
drivers/md/dm-io.c | 7 +++----
drivers/md/dm.c | 12 ++++++++++++
drivers/md/dm.h | 2 ++
3 files changed, 17 insertions(+), 4 deletions(-)
diff --git a/drivers/md/dm-io.c b/drivers/md/dm-io.c
index ea49834..2a20986 100644
--- a/drivers/md/dm-io.c
+++ b/drivers/md/dm-io.c
@@ -19,8 +19,6 @@
#define DM_MSG_PREFIX "io"
#define DM_IO_MAX_REGIONS BITS_PER_LONG
-#define MIN_IOS 16
-#define MIN_BIOS 16
struct dm_io_client {
mempool_t *pool;
@@ -50,16 +48,17 @@ static struct kmem_cache *_dm_io_cache;
struct dm_io_client *dm_io_client_create(void)
{
struct dm_io_client *client;
+ unsigned min_ios = dm_get_reserved_bio_based_ios();
client = kmalloc(sizeof(*client), GFP_KERNEL);
if (!client)
return ERR_PTR(-ENOMEM);
- client->pool = mempool_create_slab_pool(MIN_IOS, _dm_io_cache);
+ client->pool = mempool_create_slab_pool(min_ios, _dm_io_cache);
if (!client->pool)
goto bad;
- client->bios = bioset_create(MIN_BIOS, 0);
+ client->bios = bioset_create(min_ios, 0);
if (!client->bios)
goto bad;
diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index b44ae19..3f96c86 100644
--- a/drivers/md/dm.c
+++ b/drivers/md/dm.c
@@ -259,6 +259,18 @@ static void __reserved_bio_based_ios_refresh(void)
}
}
+unsigned dm_get_reserved_bio_based_ios(void)
+{
+ unsigned ios;
+
+ mutex_lock(&dm_mempools_lock);
+ ios = reserved_bio_based_ios_latch;
+ mutex_unlock(&dm_mempools_lock);
+
+ return (ios ? : RESERVED_BIO_BASED_IOS);
+}
+EXPORT_SYMBOL_GPL(dm_get_reserved_bio_based_ios);
+
static void __reserved_request_based_ios_refresh(void)
{
BUG_ON(!mutex_is_locked(&dm_mempools_lock));
diff --git a/drivers/md/dm.h b/drivers/md/dm.h
index 5e604cc..e1982eb 100644
--- a/drivers/md/dm.h
+++ b/drivers/md/dm.h
@@ -184,6 +184,8 @@ void dm_free_md_mempools(struct dm_md_mempools *pools);
/*
* Helpers that are used by DM core
*/
+unsigned dm_get_reserved_bio_based_ios(void);
+
static inline bool dm_message_test_buffer_overflow(char *result, unsigned maxlen)
{
return !maxlen || strlen(result) + 1 >= maxlen;
--
1.8.1.4
next prev parent reply other threads:[~2013-09-12 22:24 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1376070533.26057.244.camel@bobble.lax.corp.google.com>
2013-08-17 12:30 ` [dm-devel] [PATCH] dm: Make MIN_IOS, et al, tunable via sysctl Alasdair G Kergon
2013-08-19 13:40 ` Mike Snitzer
2013-08-19 15:04 ` Frank Mayhar
2013-08-19 14:00 ` Mike Snitzer
2013-08-19 17:54 ` [dm-devel] " Frank Mayhar
2013-08-19 18:15 ` Mike Snitzer
2013-08-20 21:44 ` [dm-devel] " Mikulas Patocka
2013-08-20 21:52 ` Frank Mayhar
2013-08-20 21:41 ` Mikulas Patocka
2013-08-20 21:22 ` [dm-devel] [PATCH] " Mikulas Patocka
2013-08-20 21:28 ` Frank Mayhar
2013-08-20 21:47 ` Mikulas Patocka
2013-08-20 21:57 ` Frank Mayhar
2013-08-20 22:24 ` Mike Snitzer
2013-08-20 22:52 ` Mikulas Patocka
2013-08-20 23:14 ` Frank Mayhar
2013-08-22 17:26 ` Frank Mayhar
2013-08-26 14:28 ` Mikulas Patocka
2013-09-12 22:24 ` [PATCH 0/7] dm: allow mempool and bioset reserves to be tuned Mike Snitzer
2013-09-12 22:24 ` [PATCH 1/7] dm: lower bio-based mempool reservation Mike Snitzer
2013-09-12 22:40 ` Mikulas Patocka
2013-09-12 22:24 ` [PATCH 2/7] dm: add reserved_rq_based_ios module parameter Mike Snitzer
2013-09-12 22:45 ` Mikulas Patocka
2013-09-12 23:15 ` Mike Snitzer
2013-09-12 23:27 ` Mikulas Patocka
2013-09-12 23:32 ` Mike Snitzer
2013-09-12 22:24 ` [PATCH 3/7] dm: add reserved_bio_based_ios " Mike Snitzer
2013-09-12 22:47 ` Mikulas Patocka
2013-09-12 23:11 ` Mike Snitzer
2013-09-12 23:17 ` Mikulas Patocka
2013-09-18 15:17 ` Frank Mayhar
2013-09-12 22:24 ` Mike Snitzer [this message]
2013-09-12 22:48 ` [PATCH 4/7] dm io: use dm_get_reserved_bio_based_ios to size reserves Mikulas Patocka
2013-09-12 22:24 ` [PATCH 5/7] dm mpath: use dm_get_reserved_rq_based_ios to size mempool Mike Snitzer
2013-09-12 22:48 ` Mikulas Patocka
2013-09-12 22:24 ` [PATCH 6/7] dm: track the maximum number of bios in a cloned request Mike Snitzer
2013-09-12 22:55 ` Mikulas Patocka
2013-09-12 23:09 ` Mike Snitzer
2013-09-12 22:24 ` [PATCH 7/7] dm: optimize clone_rq() when track_peak_rq_based_ios is disabled Mike Snitzer
2013-09-12 23:00 ` Mikulas Patocka
2013-09-12 23:06 ` Mike Snitzer
2013-09-12 23:30 ` Mikulas Patocka
2013-09-12 23:53 ` Mike Snitzer
2013-09-13 4:46 ` Jun'ichi Nomura
2013-09-13 13:04 ` Mike Snitzer
2013-09-13 14:34 ` Mikulas Patocka
2013-09-13 18:59 ` [PATCH v2 0/3] dm: allow mempool and bioset reserves to be tuned Mike Snitzer
2013-09-13 18:59 ` [PATCH v2 1/3] dm: lower bio-based mempool reservation Mike Snitzer
2013-09-13 18:59 ` [PATCH v2 2/3] dm: add reserved_rq_based_ios module parameter Mike Snitzer
2013-09-13 18:59 ` [PATCH v2 3/3] dm: add reserved_bio_based_ios " Mike Snitzer
2013-09-13 19:22 ` [PATCH v2 0/3] dm: allow mempool and bioset reserves to be tuned Mike Snitzer
2013-09-13 20:30 ` Mike Snitzer
2013-09-13 21:08 ` [PATCH v3 " Mike Snitzer
2013-09-13 21:08 ` [PATCH v3 1/3] dm: lower bio-based mempool reservation Mike Snitzer
2013-09-13 21:08 ` [PATCH v3 2/3] dm: add reserved_rq_based_ios module parameter Mike Snitzer
2013-09-13 21:08 ` [PATCH v3 3/3] dm: add reserved_bio_based_ios " Mike Snitzer
2013-09-18 15:10 ` [PATCH v3 0/3] dm: allow mempool and bioset reserves to be tuned Frank Mayhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379024698-10487-5-git-send-email-snitzer@redhat.com \
--to=snitzer@redhat.com \
--cc=dm-devel@redhat.com \
--cc=fmayhar@google.com \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).