Linux Device Mapper development
 help / color / mirror / Atom feed
From: Andy Grover <agrover@redhat.com>
To: dm-devel@redhat.com
Subject: [PATCH 1/2] dm-raid: Fix minimal device check
Date: Wed, 28 Oct 2015 11:50:00 -0700	[thread overview]
Message-ID: <1446058201-12628-1-git-send-email-agrover@redhat.com> (raw)

Check raid_type->minimal_devs instead of parity_devs. minimal_devs is used
nowhere else (and makes sense to use here) so I think this is what was
intended.

Signed-off-by: Andy Grover <agrover@redhat.com>
---
 drivers/md/dm-raid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index a090121..5941cfd 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -151,7 +151,7 @@ static struct raid_set *context_alloc(struct dm_target *ti, struct raid_type *ra
 	unsigned i;
 	struct raid_set *rs;
 
-	if (raid_devs <= raid_type->parity_devs) {
+	if (raid_devs < raid_type->minimal_devs) {
 		ti->error = "Insufficient number of devices";
 		return ERR_PTR(-EINVAL);
 	}
-- 
2.4.3

             reply	other threads:[~2015-10-28 18:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-28 18:50 Andy Grover [this message]
2015-10-28 18:50 ` [PATCH 2/2] dm-raid: Fix minimal_devs for raid6 Andy Grover
2015-10-28 19:17   ` Heinz Mauelshagen
2015-10-28 19:39 ` [PATCH 1/2] dm-raid: Fix minimal device check Heinz Mauelshagen
2015-10-28 22:16   ` Andy Grover

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1446058201-12628-1-git-send-email-agrover@redhat.com \
    --to=agrover@redhat.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox