From: heinzm@redhat.com
To: dm-devel@redhat.com
Cc: Heinz Mauelshagen <heinzm@redhat.com>
Subject: [PATCH] dm raid1: the device-mapper 'mirror' target errors written bios erroneously
Date: Wed, 23 Mar 2016 21:06:27 +0100 [thread overview]
Message-ID: <1458763587-9307-1-git-send-email-heinzm@redhat.com> (raw)
From: Heinz Mauelshagen <heinzm@redhat.com>
The device-mapper 'mirror' target errors correctly written
bios erroneously in hold_bio() in case the mapped device is
suspended and flushs are allowed.
Because the caller already copes with erroring such bios in
case all mirror legs got failed, any getting to hold_bio()
are good, thus the patch sets bio->bi_error to 0.
Resolves: rhbz1307111
---
drivers/md/dm-raid1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/dm-raid1.c b/drivers/md/dm-raid1.c
index b3ccf1e..2285ab2 100644
--- a/drivers/md/dm-raid1.c
+++ b/drivers/md/dm-raid1.c
@@ -492,7 +492,7 @@ static void hold_bio(struct mirror_set *ms, struct bio *bio)
if (dm_noflush_suspending(ms->ti))
bio->bi_error = DM_ENDIO_REQUEUE;
else
- bio->bi_error = -EIO;
+ bio->bi_error = 0;
bio_endio(bio);
return;
--
2.5.0
next reply other threads:[~2016-03-23 20:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 20:06 heinzm [this message]
2016-03-24 17:52 ` dm raid1: the device-mapper 'mirror' target errors written bios erroneously Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458763587-9307-1-git-send-email-heinzm@redhat.com \
--to=heinzm@redhat.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).