* [PATCH 2/9] multipath-tools: remove spaces in S390 devices
2016-06-21 0:35 [PATCH 1/9] multipath-tools: add iSCSI product id for TEGILE ZEBI Xose Vazquez Perez
@ 2016-06-21 0:35 ` Xose Vazquez Perez
2016-06-21 0:35 ` [PATCH 3/9] multipath-tools: reduce regex for DGC CLARiiON CX/AX and EMC VNX Xose Vazquez Perez
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Xose Vazquez Perez @ 2016-06-21 0:35 UTC (permalink / raw)
Cc: device-mapper development, Xose Vazquez Perez
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
libmultipath/hwtable.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index fb38320..206d1fd 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -611,7 +611,7 @@ static struct hwentry default_hw[] = {
/* IBM S/390 ECKD DASD */
.vendor = "IBM",
.product = "S/390 DASD ECKD",
- .bl_product = "S/390.*",
+ .bl_product = "S/390.*",
.uid_attribute = "ID_UID",
.features = "1 queue_if_no_path",
.hwhandler = DEFAULT_HWHANDLER,
@@ -627,7 +627,7 @@ static struct hwentry default_hw[] = {
/* IBM S/390 FBA DASD */
.vendor = "IBM",
.product = "S/390 DASD FBA",
- .bl_product = "S/390.*",
+ .bl_product = "S/390.*",
.uid_attribute = "ID_UID",
.features = "1 queue_if_no_path",
.hwhandler = DEFAULT_HWHANDLER,
--
2.5.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 3/9] multipath-tools: reduce regex for DGC CLARiiON CX/AX and EMC VNX
2016-06-21 0:35 [PATCH 1/9] multipath-tools: add iSCSI product id for TEGILE ZEBI Xose Vazquez Perez
2016-06-21 0:35 ` [PATCH 2/9] multipath-tools: remove spaces in S390 devices Xose Vazquez Perez
@ 2016-06-21 0:35 ` Xose Vazquez Perez
2016-06-21 0:35 ` [PATCH 4/9] multipath-tools: unify DELL MD32xx and MD36xx Xose Vazquez Perez
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Xose Vazquez Perez @ 2016-06-21 0:35 UTC (permalink / raw)
Cc: device-mapper development, Xose Vazquez Perez
vendor="DGC" and product=".*" is tooooo broad.
Using same product labels as in drivers/scsi/scsi_dh.c
Field-tested with Clariion VNX7500.
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
libmultipath/hwtable.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 206d1fd..a8dc0de 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -267,8 +267,8 @@ static struct hwentry default_hw[] = {
},
{
/* DGC CLARiiON CX/AX and EMC VNX */
- .vendor = "DGC",
- .product = ".*",
+ .vendor = "^DGC",
+ .product = "^RAID|^DISK|^VRAID",
.bl_product = "LUNZ",
.features = "1 queue_if_no_path",
.hwhandler = "1 emc",
--
2.5.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 4/9] multipath-tools: unify DELL MD32xx and MD36xx
2016-06-21 0:35 [PATCH 1/9] multipath-tools: add iSCSI product id for TEGILE ZEBI Xose Vazquez Perez
2016-06-21 0:35 ` [PATCH 2/9] multipath-tools: remove spaces in S390 devices Xose Vazquez Perez
2016-06-21 0:35 ` [PATCH 3/9] multipath-tools: reduce regex for DGC CLARiiON CX/AX and EMC VNX Xose Vazquez Perez
@ 2016-06-21 0:35 ` Xose Vazquez Perez
2016-06-21 0:36 ` [PATCH 5/9] multipath-tools: add DELL MD34xx/MD38xx Xose Vazquez Perez
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Xose Vazquez Perez @ 2016-06-21 0:35 UTC (permalink / raw)
Cc: device-mapper development, Xose Vazquez Perez
They belong same family and share FW:
https://downloads.dell.com/manuals/common/md32xx_md36xx_supportmatrix2_en-us.pdf
The main differences are:
MD3200 6 Gbps direct attached SAS storage array with 12 drives (3.5 inch)
MD3220 6 Gbps direct attached SAS storage array with 24 drives (2.5 inch)
MD3260 6 Gbps direct Attached SAS storage dense array
MD3200i 1 Gbps iSCSI network storage array with 12 drives (3.5 inch)
MD3600i 10 Gbps iSCSI network storage array with 12 drives (3.5 inch)
MD3220i 1 Gbps iSCSI network storage array with 24 drives (2.5 inch)
MD3620i 10 Gbps iSCSI network storage array with 24 drives (2.5 inch)
MD3260i 1 Gbps iSCSI network storage dense array
MD3660i 10 Gbps iSCSI network storage dense array
MD3600f 8 Gbps fibre channel network storage array with 12 drives (3.5 inch)
MD3620f 8 Gbps fibre channel network storage array with 24 drives (2.5 inch)
MD3660f 8 Gbps fibre channel network storage dense array
A mandatory ACK from Hannes is required, as he was reluctant to unify them.
Cc: Hannes Reinecke <hare@suse.de>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
libmultipath/hwtable.c | 21 +++------------------
1 file changed, 3 insertions(+), 18 deletions(-)
diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index a8dc0de..031102c 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -735,7 +735,7 @@ static struct hwentry default_hw[] = {
* DELL
*/
{
- /* DELL MD3000/MD3000i */
+ /* DELL MD3000 */
.vendor = "DELL",
.product = "MD3000",
.bl_product = "Universal Xport",
@@ -750,24 +750,9 @@ static struct hwentry default_hw[] = {
.prio_args = NULL,
},
{
- /* DELL MD32xx/MD32xxi */
+ /* DELL MD32xx/MD36xx */
.vendor = "DELL",
- .product = "MD32xx",
- .bl_product = "Universal Xport",
- .features = "2 pg_init_retries 50",
- .hwhandler = "1 rdac",
- .pgpolicy = GROUP_BY_PRIO,
- .pgfailback = -FAILBACK_IMMEDIATE,
- .rr_weight = RR_WEIGHT_NONE,
- .no_path_retry = 15,
- .checker_name = RDAC,
- .prio_name = PRIO_RDAC,
- .prio_args = NULL,
- },
- {
- /* DELL MD36xxi/MD36xxf */
- .vendor = "DELL",
- .product = "MD36xx(i|f)",
+ .product = "MD32xx|MD36xx",
.bl_product = "Universal Xport",
.features = "2 pg_init_retries 50",
.hwhandler = "1 rdac",
--
2.5.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 5/9] multipath-tools: add DELL MD34xx/MD38xx
2016-06-21 0:35 [PATCH 1/9] multipath-tools: add iSCSI product id for TEGILE ZEBI Xose Vazquez Perez
` (2 preceding siblings ...)
2016-06-21 0:35 ` [PATCH 4/9] multipath-tools: unify DELL MD32xx and MD36xx Xose Vazquez Perez
@ 2016-06-21 0:36 ` Xose Vazquez Perez
2016-06-21 0:36 ` [PATCH 6/9] multipath-tools: do not track temp vim files and patches Xose Vazquez Perez
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Xose Vazquez Perez @ 2016-06-21 0:36 UTC (permalink / raw)
Cc: device-mapper development, Xose Vazquez Perez
New MD34xx/MD38xx family based also on RDAC:
http://downloads.dell.com/manuals/common/md34xx_md38xx_support%20matrix2_en-us.pdf
MD3400 12 Gbps direct attached SAS storage array with 12 drives (3.5 inch)
MD3420 12 Gbps direct attached SAS storage array with 24 drives (2.5 inch)
MD3460 12 Gbps direct attached SAS storage dense array
MD3800i 10 Gbps iSCSI network storage array with 12 drives (3.5 inch)
MD3820i 10 Gbps iSCSI network storage array with 24 drives (2.5 inch)
MD3860i 10 Gbps iSCSI network storage dense array
MD3800f 16 Gbps FC network storage array with 12 drives (3.5 inch)
MD3820f 16 Gbps FC network storage array with 24 drives (2.5 inch)
MD3860f 16 Gbps FC network storage dense array
Cc: Hannes Reinecke <hare@suse.de>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
libmultipath/hwtable.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 031102c..62e284d 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -764,6 +764,21 @@ static struct hwentry default_hw[] = {
.prio_name = PRIO_RDAC,
.prio_args = NULL,
},
+ {
+ /* DELL MD34xx/MD38xx */
+ .vendor = "DELL",
+ .product = "MD34xx|MD38xx",
+ .bl_product = "Universal Xport",
+ .features = "2 pg_init_retries 50",
+ .hwhandler = "1 rdac",
+ .pgpolicy = GROUP_BY_PRIO,
+ .pgfailback = -FAILBACK_IMMEDIATE,
+ .rr_weight = RR_WEIGHT_NONE,
+ .no_path_retry = 15,
+ .checker_name = RDAC,
+ .prio_name = PRIO_RDAC,
+ .prio_args = NULL,
+ },
/*
* NETAPP
*/
--
2.5.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 6/9] multipath-tools: do not track temp vim files and patches
2016-06-21 0:35 [PATCH 1/9] multipath-tools: add iSCSI product id for TEGILE ZEBI Xose Vazquez Perez
` (3 preceding siblings ...)
2016-06-21 0:36 ` [PATCH 5/9] multipath-tools: add DELL MD34xx/MD38xx Xose Vazquez Perez
@ 2016-06-21 0:36 ` Xose Vazquez Perez
2016-06-21 0:36 ` [PATCH 7/9] multipath-tools: tips on adding new devices with proprietary handlers Xose Vazquez Perez
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Xose Vazquez Perez @ 2016-06-21 0:36 UTC (permalink / raw)
Cc: device-mapper development, Xose Vazquez Perez
add *.swp and *.patch to .gitignore
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
.gitignore | 2 ++
1 file changed, 2 insertions(+)
diff --git a/.gitignore b/.gitignore
index 7f25d0e..aee4ece 100644
--- a/.gitignore
+++ b/.gitignore
@@ -10,3 +10,5 @@ multipath/multipath
multipathd/multipathd
mpathpersist/mpathpersist
.nfs*
+*.swp
+*.patch
--
2.5.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 7/9] multipath-tools: tips on adding new devices with proprietary handlers
2016-06-21 0:35 [PATCH 1/9] multipath-tools: add iSCSI product id for TEGILE ZEBI Xose Vazquez Perez
` (4 preceding siblings ...)
2016-06-21 0:36 ` [PATCH 6/9] multipath-tools: do not track temp vim files and patches Xose Vazquez Perez
@ 2016-06-21 0:36 ` Xose Vazquez Perez
2016-06-21 0:36 ` [PATCH 8/9] multipath-tools: fix syntax in mpath_persistent_reserve_out.3 Xose Vazquez Perez
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Xose Vazquez Perez @ 2016-06-21 0:36 UTC (permalink / raw)
Cc: Xose Vazquez Perez, device-mapper development, Babu Moger,
Sean Stewart
kernel(SCSI) and multipath-tools should be in sync.
Currently in drivers/scsi/scsi_dh.c:
{"DGC", "RAID", "clariion" },
{"DGC", "DISK", "clariion" },
{"DGC", "VRAID", "clariion" },
{"COMPAQ", "MSA1000 VOLUME", "hp_sw" },
{"COMPAQ", "HSV110", "hp_sw" },
{"HP", "HSV100", "hp_sw"},
{"DEC", "HSG80", "hp_sw"},
{"IBM", "1722", "rdac", },
{"IBM", "1724", "rdac", },
{"IBM", "1726", "rdac", },
{"IBM", "1742", "rdac", },
{"IBM", "1745", "rdac", },
{"IBM", "1746", "rdac", },
{"IBM", "1813", "rdac", }, -> missing in multipath-tools !!!
Added in 4df01b. It's an IBM DCS3860.
{"IBM", "1814", "rdac", },
{"IBM", "1815", "rdac", },
{"IBM", "1818", "rdac", },
{"IBM", "3526", "rdac", },
{"SGI", "TP9", "rdac", },
{"SGI", "IS", "rdac", },
{"STK", "OPENstorage D280", "rdac", },
{"STK", "FLEXLINE 380", "rdac", },
{"SUN", "CSM", "rdac", },
{"SUN", "LCSM100", "rdac", },
{"SUN", "STK6580_6780", "rdac", },
{"SUN", "SUN_6180", "rdac", },
{"SUN", "ArrayStorage", "rdac", }, -> missing in multipath-tools !!!
Added in 66195f. Unknown device, too generic name.
{"DELL", "MD3", "rdac", },
{"NETAPP", "INF-01-00", "rdac", },
{"LSI", "INF-01-00", "rdac", },
{"ENGENIO", "INF-01-00", "rdac", },
Cc: Babu Moger <Babu.Moger@netapp.com>
Cc: Sean Stewart <sean.stewart@netapp.com>
Cc: Benjamin Marzinski <bmarzins@redhat.com>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
libmultipath/hwtable.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 62e284d..47a2e61 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -15,6 +15,11 @@
* You are welcome to claim maintainership over a controller
* family. Please mail the currently enlisted maintainer and
* the upstream package maintainer.
+ *
+ * WARNING:
+ *
+ * Devices with a proprietary handler must also be included in
+ * the kernel side. Currently at drivers/scsi/scsi_dh.c
*/
static struct hwentry default_hw[] = {
/*
--
2.5.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 8/9] multipath-tools: fix syntax in mpath_persistent_reserve_out.3
2016-06-21 0:35 [PATCH 1/9] multipath-tools: add iSCSI product id for TEGILE ZEBI Xose Vazquez Perez
` (5 preceding siblings ...)
2016-06-21 0:36 ` [PATCH 7/9] multipath-tools: tips on adding new devices with proprietary handlers Xose Vazquez Perez
@ 2016-06-21 0:36 ` Xose Vazquez Perez
2016-06-21 0:36 ` [PATCH 9/9] multipath-tools: minor edit in hwtable Xose Vazquez Perez
2016-07-08 6:36 ` [PATCH 1/9] multipath-tools: add iSCSI product id for TEGILE ZEBI Christophe Varoqui
8 siblings, 0 replies; 10+ messages in thread
From: Xose Vazquez Perez @ 2016-06-21 0:36 UTC (permalink / raw)
Cc: device-mapper development, Xose Vazquez Perez
./libmpathpersist/mpath_persistent_reserve_out.3:91: warning: tab character in unquoted macro argument
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
libmpathpersist/mpath_persistent_reserve_out.3 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libmpathpersist/mpath_persistent_reserve_out.3 b/libmpathpersist/mpath_persistent_reserve_out.3
index 7e57d2b..8a3b52c 100644
--- a/libmpathpersist/mpath_persistent_reserve_out.3
+++ b/libmpathpersist/mpath_persistent_reserve_out.3
@@ -88,5 +88,5 @@ sends PR OUT command to the DM device and gets the response.
.SH "SEE ALSO"
-.I mpath_persistent_reserve_in mpathpersist /usr/share/doc/mpathpersist/README
+.I mpath_persistent_reserve_in mpathpersist /usr/share/doc/mpathpersist/README
.br
--
2.5.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 9/9] multipath-tools: minor edit in hwtable
2016-06-21 0:35 [PATCH 1/9] multipath-tools: add iSCSI product id for TEGILE ZEBI Xose Vazquez Perez
` (6 preceding siblings ...)
2016-06-21 0:36 ` [PATCH 8/9] multipath-tools: fix syntax in mpath_persistent_reserve_out.3 Xose Vazquez Perez
@ 2016-06-21 0:36 ` Xose Vazquez Perez
2016-07-08 6:36 ` [PATCH 1/9] multipath-tools: add iSCSI product id for TEGILE ZEBI Christophe Varoqui
8 siblings, 0 replies; 10+ messages in thread
From: Xose Vazquez Perez @ 2016-06-21 0:36 UTC (permalink / raw)
Cc: device-mapper development, Xose Vazquez Perez
delete empty lines and correct a NEC product.
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
libmultipath/hwtable.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 47a2e61..fb334ab 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -189,7 +189,6 @@ static struct hwentry default_hw[] = {
.prio_name = PRIO_ALUA,
.prio_args = NULL,
},
-
{
/* HP SVSP */
.vendor = "HP",
@@ -205,7 +204,6 @@ static struct hwentry default_hw[] = {
.prio_name = PRIO_ALUA,
.prio_args = NULL,
},
-
{
/* HP Smart Array */
.vendor = "HP",
@@ -861,7 +859,6 @@ static struct hwentry default_hw[] = {
.prio_name = PRIO_ALUA,
.prio_args = NULL,
},
-
/*
* SGI
*/
@@ -910,7 +907,7 @@ static struct hwentry default_hw[] = {
* NEC
*/
{
- /* Storage M Series */
+ /* M-Series */
.vendor = "NEC",
.product = "DISK ARRAY",
.features = DEFAULT_FEATURES,
--
2.5.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 1/9] multipath-tools: add iSCSI product id for TEGILE ZEBI
2016-06-21 0:35 [PATCH 1/9] multipath-tools: add iSCSI product id for TEGILE ZEBI Xose Vazquez Perez
` (7 preceding siblings ...)
2016-06-21 0:36 ` [PATCH 9/9] multipath-tools: minor edit in hwtable Xose Vazquez Perez
@ 2016-07-08 6:36 ` Christophe Varoqui
8 siblings, 0 replies; 10+ messages in thread
From: Christophe Varoqui @ 2016-07-08 6:36 UTC (permalink / raw)
To: Xose Vazquez Perez; +Cc: device-mapper development
[-- Attachment #1.1: Type: text/plain, Size: 1050 bytes --]
All nine patches of this set are merged.
Thanks.
On Tue, Jun 21, 2016 at 2:35 AM, Xose Vazquez Perez <xose.vazquez@gmail.com>
wrote:
> Devices running 2.x firmware has a different product id for iSCSI.
>
> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> Cc: device-mapper development <dm-devel@redhat.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
> libmultipath/hwtable.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> index 6116124..fb38320 100644
> --- a/libmultipath/hwtable.c
> +++ b/libmultipath/hwtable.c
> @@ -1195,7 +1195,7 @@ static struct hwentry default_hw[] = {
> */
> {
> .vendor = "TEGILE",
> - .product = "ZEBI-FC|INTELLIFLASH",
> + .product = "ZEBI-(FC|ISCSI)|INTELLIFLASH",
> .hwhandler = "1 alua",
> .selector = "round-robin 0",
> .pgpolicy = GROUP_BY_PRIO,
> --
> 2.5.5
>
>
[-- Attachment #1.2: Type: text/html, Size: 1775 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread