* [PATCH 1/5] multipath-tools: replace rm with a variable in makefiles
2016-07-01 17:17 [PATCH 0/5] Makefiles housekeeping II Xose Vazquez Perez
@ 2016-07-01 17:17 ` Xose Vazquez Perez
2016-07-01 17:17 ` [PATCH 2/5] multipath-tools: replace install with its " Xose Vazquez Perez
` (4 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Xose Vazquez Perez @ 2016-07-01 17:17 UTC (permalink / raw)
Cc: device-mapper development, Xose Vazquez Perez
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
Makefile.inc | 1 +
kpartx/Makefile | 12 ++++++------
libmpathcmd/Makefile | 8 ++++----
libmpathpersist/Makefile | 18 +++++++++---------
libmultipath/Makefile | 4 ++--
libmultipath/checkers/Makefile | 4 ++--
libmultipath/prioritizers/Makefile | 4 ++--
mpathpersist/Makefile | 8 ++++----
multipath/Makefile | 12 ++++++------
multipathd/Makefile | 10 +++++-----
10 files changed, 41 insertions(+), 40 deletions(-)
diff --git a/Makefile.inc b/Makefile.inc
index 7adeb46..e5d8704 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -56,6 +56,7 @@ mpathpersistdir = $(TOPDIR)/libmpathpersist
mpathcmddir = $(TOPDIR)/libmpathcmd
GZIP = gzip -9 -c
+RM = rm -f
INSTALL_PROGRAM = install
OPTFLAGS = -Wunused -Wstrict-prototypes -O2 -g -pipe -Wformat-security -Wall \
diff --git a/kpartx/Makefile b/kpartx/Makefile
index 501b277..5476545 100644
--- a/kpartx/Makefile
+++ b/kpartx/Makefile
@@ -34,11 +34,11 @@ install: $(EXEC) $(EXEC).8
$(INSTALL_PROGRAM) -m 644 $(EXEC).8.gz $(DESTDIR)$(mandir)
uninstall:
- rm -f $(DESTDIR)$(bindir)/$(EXEC)
- rm -f $(DESTDIR)$(mandir)/$(EXEC).8.gz
- rm -f $(DESTDIR)$(libudevdir)/kpartx_id
- rm -f $(DESTDIR)$(libudevdir)/rules.d/66-kpartx.rules
- rm -f $(DESTDIR)$(libudevdir)/rules.d/67-kpartx-compat.rules
+ $(RM) $(DESTDIR)$(bindir)/$(EXEC)
+ $(RM) $(DESTDIR)$(mandir)/$(EXEC).8.gz
+ $(RM) $(DESTDIR)$(libudevdir)/kpartx_id
+ $(RM) $(DESTDIR)$(libudevdir)/rules.d/66-kpartx.rules
+ $(RM) $(DESTDIR)$(libudevdir)/rules.d/67-kpartx-compat.rules
clean:
- rm -f core *.o $(EXEC) *.gz
+ $(RM) core *.o $(EXEC) *.gz
diff --git a/libmpathcmd/Makefile b/libmpathcmd/Makefile
index 6fca165..92cdd82 100644
--- a/libmpathcmd/Makefile
+++ b/libmpathcmd/Makefile
@@ -22,9 +22,9 @@ install: $(LIBS)
$(INSTALL_PROGRAM) -m 644 mpath_cmd.h $(DESTDIR)$(incdir)
uninstall:
- rm -f $(DESTDIR)$(syslibdir)/$(LIBS)
- rm -f $(DESTDIR)$(syslibdir)/$(DEVLIB)
- rm -f $(DESTDIR)$(incdir)/mpath_cmd.h
+ $(RM) $(DESTDIR)$(syslibdir)/$(LIBS)
+ $(RM) $(DESTDIR)$(syslibdir)/$(DEVLIB)
+ $(RM) $(DESTDIR)$(incdir)/mpath_cmd.h
clean:
- rm -f core *.a *.o *.gz *.so *.so.*
+ $(RM) core *.a *.o *.gz *.so *.so.*
diff --git a/libmpathpersist/Makefile b/libmpathpersist/Makefile
index e6a7eb8..09d196e 100644
--- a/libmpathpersist/Makefile
+++ b/libmpathpersist/Makefile
@@ -38,14 +38,14 @@ install: $(LIBS)
install -m 644 mpath_persist.h $(DESTDIR)$(incdir)
uninstall:
- rm -f $(DESTDIR)$(syslibdir)/$(LIBS)
- rm $(DESTDIR)$(man3dir)/mpath_persistent_reserve_in.3.gz
- rm $(DESTDIR)$(man3dir)/mpath_persistent_reserve_out.3.gz
- rm -f $(DESTDIR)$(incdir)/mpath_persist.h
- rm -f $(DESTDIR)$(syslibdir)/$(DEVLIB)
+ $(RM) $(DESTDIR)$(syslibdir)/$(LIBS)
+ $(RM) $(DESTDIR)$(man3dir)/mpath_persistent_reserve_in.3.gz
+ $(RM) $(DESTDIR)$(man3dir)/mpath_persistent_reserve_out.3.gz
+ $(RM) $(DESTDIR)$(incdir)/mpath_persist.h
+ $(RM) $(DESTDIR)$(syslibdir)/$(DEVLIB)
clean:
- rm -f core *.a *.o
- rm -f libmpathpersist.so.0
- rm -f libmpathpersist.so
- rm -f mpath_persistent_reserve_in.3.gz mpath_persistent_reserve_out.3.gz
+ $(RM) core *.a *.o
+ $(RM) libmpathpersist.so.0
+ $(RM) libmpathpersist.so
+ $(RM) mpath_persistent_reserve_in.3.gz mpath_persistent_reserve_out.3.gz
diff --git a/libmultipath/Makefile b/libmultipath/Makefile
index 1ee968e..ba1cfa7 100644
--- a/libmultipath/Makefile
+++ b/libmultipath/Makefile
@@ -65,7 +65,7 @@ install:
$(INSTALL_PROGRAM) -m 755 -d $(DESTDIR)$(libdir)
uninstall:
- rm -f $(DESTDIR)$(syslibdir)/$(LIBS)
+ $(RM) $(DESTDIR)$(syslibdir)/$(LIBS)
clean:
- rm -f core *.a *.o *.gz *.so *.so.*
+ $(RM) core *.a *.o *.gz *.so *.so.*
diff --git a/libmultipath/checkers/Makefile b/libmultipath/checkers/Makefile
index 4b1a108..fb8fff0 100644
--- a/libmultipath/checkers/Makefile
+++ b/libmultipath/checkers/Makefile
@@ -27,7 +27,7 @@ install:
$(INSTALL_PROGRAM) -m 755 $(LIBS) $(DESTDIR)$(libdir)
uninstall:
- for file in $(LIBS); do rm -f $(DESTDIR)$(libdir)/$$file; done
+ for file in $(LIBS); do $(RM) $(DESTDIR)$(libdir)/$$file; done
clean:
- rm -f core *.a *.o *.gz *.so
+ $(RM) core *.a *.o *.gz *.so
diff --git a/libmultipath/prioritizers/Makefile b/libmultipath/prioritizers/Makefile
index ca7b85c..903a139 100644
--- a/libmultipath/prioritizers/Makefile
+++ b/libmultipath/prioritizers/Makefile
@@ -31,7 +31,7 @@ install: $(LIBS)
$(INSTALL_PROGRAM) -m 755 libprio*.so $(DESTDIR)$(libdir)
uninstall:
- for file in $(LIBS); do rm -f $(DESTDIR)$(libdir)/$$file; done
+ for file in $(LIBS); do $(RM) $(DESTDIR)$(libdir)/$$file; done
clean:
- rm -f core *.a *.o *.gz *.so
+ $(RM) core *.a *.o *.gz *.so
diff --git a/mpathpersist/Makefile b/mpathpersist/Makefile
index 42a0830..2cc625b 100644
--- a/mpathpersist/Makefile
+++ b/mpathpersist/Makefile
@@ -22,9 +22,9 @@ install:
install -m 644 $(EXEC).8.gz $(DESTDIR)$(mandir)
clean:
- rm -f *.o $(EXEC)
- rm -f mpathpersist.8.gz
+ $(RM) *.o $(EXEC)
+ $(RM) mpathpersist.8.gz
uninstall:
- rm $(DESTDIR)$(bindir)/$(EXEC)
- rm $(DESTDIR)$(mandir)/$(EXEC).8.gz
+ $(RM) $(DESTDIR)$(bindir)/$(EXEC)
+ $(RM) $(DESTDIR)$(mandir)/$(EXEC).8.gz
diff --git a/multipath/Makefile b/multipath/Makefile
index 3707235..9c57d3b 100644
--- a/multipath/Makefile
+++ b/multipath/Makefile
@@ -31,11 +31,11 @@ install:
$(INSTALL_PROGRAM) -m 644 $(EXEC).conf.5.gz $(DESTDIR)$(man5dir)
uninstall:
- rm $(DESTDIR)$(bindir)/$(EXEC)
- rm $(DESTDIR)$(udevrulesdir)/11-dm-mpath.rules
- rm $(DESTDIR)$(libudevdir)/rules.d/56-multipath.rules
- rm $(DESTDIR)$(mandir)/$(EXEC).8.gz
- rm $(DESTDIR)$(man5dir)/$(EXEC).conf.5.gz
+ $(RM) $(DESTDIR)$(bindir)/$(EXEC)
+ $(RM) $(DESTDIR)$(udevrulesdir)/11-dm-mpath.rules
+ $(RM) $(DESTDIR)$(libudevdir)/rules.d/56-multipath.rules
+ $(RM) $(DESTDIR)$(mandir)/$(EXEC).8.gz
+ $(RM) $(DESTDIR)$(man5dir)/$(EXEC).conf.5.gz
clean:
- rm -f core *.o $(EXEC) *.gz
+ $(RM) core *.o $(EXEC) *.gz
diff --git a/multipathd/Makefile b/multipathd/Makefile
index 7fb1d3f..1caaca7 100644
--- a/multipathd/Makefile
+++ b/multipathd/Makefile
@@ -55,11 +55,11 @@ endif
$(INSTALL_PROGRAM) -m 644 $(EXEC).8.gz $(DESTDIR)$(mandir)
uninstall:
- rm -f $(DESTDIR)$(bindir)/$(EXEC)
- rm -f $(DESTDIR)$(mandir)/$(EXEC).8.gz
- rm -f $(DESTDIR)$(unitdir)/$(EXEC).service
- rm -f $(DESTDIR)$(unitdir)/$(EXEC).socket
+ $(RM) $(DESTDIR)$(bindir)/$(EXEC)
+ $(RM) $(DESTDIR)$(mandir)/$(EXEC).8.gz
+ $(RM) $(DESTDIR)$(unitdir)/$(EXEC).service
+ $(RM) $(DESTDIR)$(unitdir)/$(EXEC).socket
clean:
- rm -f core *.o $(EXEC) *.gz
+ $(RM) core *.o $(EXEC) *.gz
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 2/5] multipath-tools: replace install with its variable in makefiles
2016-07-01 17:17 [PATCH 0/5] Makefiles housekeeping II Xose Vazquez Perez
2016-07-01 17:17 ` [PATCH 1/5] multipath-tools: replace rm with a variable in makefiles Xose Vazquez Perez
@ 2016-07-01 17:17 ` Xose Vazquez Perez
2016-07-01 17:17 ` [PATCH 3/5] multipath-tools: replace ln with a " Xose Vazquez Perez
` (3 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Xose Vazquez Perez @ 2016-07-01 17:17 UTC (permalink / raw)
Cc: device-mapper development, Xose Vazquez Perez
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
libmpathpersist/Makefile | 6 +++---
mpathpersist/Makefile | 8 ++++----
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/libmpathpersist/Makefile b/libmpathpersist/Makefile
index 09d196e..6afd3a8 100644
--- a/libmpathpersist/Makefile
+++ b/libmpathpersist/Makefile
@@ -33,9 +33,9 @@ install: $(LIBS)
$(INSTALL_PROGRAM) -m 755 -d $(DESTDIR)$(man3dir)
$(INSTALL_PROGRAM) -m 755 -d $(DESTDIR)$(incdir)
ln -sf $(DESTDIR)$(syslibdir)/$(LIBS) $(DESTDIR)$(syslibdir)/$(DEVLIB)
- install -m 644 mpath_persistent_reserve_in.3.gz $(DESTDIR)$(man3dir)
- install -m 644 mpath_persistent_reserve_out.3.gz $(DESTDIR)$(man3dir)
- install -m 644 mpath_persist.h $(DESTDIR)$(incdir)
+ $(INSTALL_PROGRAM) -m 644 mpath_persistent_reserve_in.3.gz $(DESTDIR)$(man3dir)
+ $(INSTALL_PROGRAM) -m 644 mpath_persistent_reserve_out.3.gz $(DESTDIR)$(man3dir)
+ $(INSTALL_PROGRAM) -m 644 mpath_persist.h $(DESTDIR)$(incdir)
uninstall:
$(RM) $(DESTDIR)$(syslibdir)/$(LIBS)
diff --git a/mpathpersist/Makefile b/mpathpersist/Makefile
index 2cc625b..df81372 100644
--- a/mpathpersist/Makefile
+++ b/mpathpersist/Makefile
@@ -16,10 +16,10 @@ $(EXEC): $(OBJS)
$(GZIP) $(EXEC).8 > $(EXEC).8.gz
install:
- install -d $(DESTDIR)$(bindir)
- install -m 755 $(EXEC) $(DESTDIR)$(bindir)/
- install -d $(DESTDIR)$(mandir)
- install -m 644 $(EXEC).8.gz $(DESTDIR)$(mandir)
+ $(INSTALL_PROGRAM) -d $(DESTDIR)$(bindir)
+ $(INSTALL_PROGRAM) -m 755 $(EXEC) $(DESTDIR)$(bindir)/
+ $(INSTALL_PROGRAM) -d $(DESTDIR)$(mandir)
+ $(INSTALL_PROGRAM) -m 644 $(EXEC).8.gz $(DESTDIR)$(mandir)
clean:
$(RM) *.o $(EXEC)
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 3/5] multipath-tools: replace ln with a variable in makefiles
2016-07-01 17:17 [PATCH 0/5] Makefiles housekeeping II Xose Vazquez Perez
2016-07-01 17:17 ` [PATCH 1/5] multipath-tools: replace rm with a variable in makefiles Xose Vazquez Perez
2016-07-01 17:17 ` [PATCH 2/5] multipath-tools: replace install with its " Xose Vazquez Perez
@ 2016-07-01 17:17 ` Xose Vazquez Perez
2016-07-01 17:17 ` [PATCH 4/5] multipath-tools: link libmpathcmd.so with full path Xose Vazquez Perez
` (2 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Xose Vazquez Perez @ 2016-07-01 17:17 UTC (permalink / raw)
Cc: device-mapper development, Xose Vazquez Perez
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
Makefile.inc | 1 +
libmpathcmd/Makefile | 4 ++--
libmpathpersist/Makefile | 4 ++--
libmultipath/Makefile | 2 +-
4 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/Makefile.inc b/Makefile.inc
index e5d8704..01d743c 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -57,6 +57,7 @@ mpathcmddir = $(TOPDIR)/libmpathcmd
GZIP = gzip -9 -c
RM = rm -f
+LN = ln -sf
INSTALL_PROGRAM = install
OPTFLAGS = -Wunused -Wstrict-prototypes -O2 -g -pipe -Wformat-security -Wall \
diff --git a/libmpathcmd/Makefile b/libmpathcmd/Makefile
index 92cdd82..44c221d 100644
--- a/libmpathcmd/Makefile
+++ b/libmpathcmd/Makefile
@@ -12,12 +12,12 @@ all: $(LIBS)
$(LIBS): $(OBJS)
$(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ $(CFLAGS) -o $@ $(OBJS) $(LIBDEPS)
- ln -sf $@ $(DEVLIB)
+ $(LN) $@ $(DEVLIB)
install: $(LIBS)
$(INSTALL_PROGRAM) -d $(DESTDIR)$(syslibdir)
$(INSTALL_PROGRAM) -m 755 $(LIBS) $(DESTDIR)$(syslibdir)/$(LIBS)
- ln -sf $(LIBS) $(DESTDIR)$(syslibdir)/$(DEVLIB)
+ $(LN) $(LIBS) $(DESTDIR)$(syslibdir)/$(DEVLIB)
$(INSTALL_PROGRAM) -d $(DESTDIR)$(incdir)
$(INSTALL_PROGRAM) -m 644 mpath_cmd.h $(DESTDIR)$(incdir)
diff --git a/libmpathpersist/Makefile b/libmpathpersist/Makefile
index 6afd3a8..d22bcdd 100644
--- a/libmpathpersist/Makefile
+++ b/libmpathpersist/Makefile
@@ -22,7 +22,7 @@ all: $(LIBS)
$(LIBS):
$(CC) -Wall -fPIC -c $(CFLAGS) *.c
$(CC) -shared $(LIBDEPS) -Wl,-soname=$@ $(CFLAGS) -o $@ $(OBJS)
- ln -s $(LIBS) $(DEVLIB)
+ $(LN) $(LIBS) $(DEVLIB)
$(GZIP) mpath_persistent_reserve_in.3 > mpath_persistent_reserve_in.3.gz
$(GZIP) mpath_persistent_reserve_out.3 > mpath_persistent_reserve_out.3.gz
@@ -32,7 +32,7 @@ install: $(LIBS)
$(INSTALL_PROGRAM) -m 755 -d $(DESTDIR)$(syslibdir)
$(INSTALL_PROGRAM) -m 755 -d $(DESTDIR)$(man3dir)
$(INSTALL_PROGRAM) -m 755 -d $(DESTDIR)$(incdir)
- ln -sf $(DESTDIR)$(syslibdir)/$(LIBS) $(DESTDIR)$(syslibdir)/$(DEVLIB)
+ $(LN) $(DESTDIR)$(syslibdir)/$(LIBS) $(DESTDIR)$(syslibdir)/$(DEVLIB)
$(INSTALL_PROGRAM) -m 644 mpath_persistent_reserve_in.3.gz $(DESTDIR)$(man3dir)
$(INSTALL_PROGRAM) -m 644 mpath_persistent_reserve_out.3.gz $(DESTDIR)$(man3dir)
$(INSTALL_PROGRAM) -m 644 mpath_persist.h $(DESTDIR)$(incdir)
diff --git a/libmultipath/Makefile b/libmultipath/Makefile
index ba1cfa7..de13e47 100644
--- a/libmultipath/Makefile
+++ b/libmultipath/Makefile
@@ -57,7 +57,7 @@ all: $(LIBS)
$(LIBS): $(OBJS)
$(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ $(CFLAGS) -o $@ $(OBJS) $(LIBDEPS)
- ln -sf $@ $(DEVLIB)
+ $(LN) $@ $(DEVLIB)
install:
$(INSTALL_PROGRAM) -d $(DESTDIR)$(syslibdir)
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 4/5] multipath-tools: link libmpathcmd.so with full path
2016-07-01 17:17 [PATCH 0/5] Makefiles housekeeping II Xose Vazquez Perez
` (2 preceding siblings ...)
2016-07-01 17:17 ` [PATCH 3/5] multipath-tools: replace ln with a " Xose Vazquez Perez
@ 2016-07-01 17:17 ` Xose Vazquez Perez
2016-07-01 17:17 ` [PATCH 5/5] multipath-tools: add a link for libmultipath.so Xose Vazquez Perez
2016-07-08 7:16 ` [PATCH 0/5] Makefiles housekeeping II Christophe Varoqui
5 siblings, 0 replies; 9+ messages in thread
From: Xose Vazquez Perez @ 2016-07-01 17:17 UTC (permalink / raw)
Cc: device-mapper development, Xose Vazquez Perez
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
libmpathcmd/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libmpathcmd/Makefile b/libmpathcmd/Makefile
index 44c221d..20710df 100644
--- a/libmpathcmd/Makefile
+++ b/libmpathcmd/Makefile
@@ -17,7 +17,7 @@ $(LIBS): $(OBJS)
install: $(LIBS)
$(INSTALL_PROGRAM) -d $(DESTDIR)$(syslibdir)
$(INSTALL_PROGRAM) -m 755 $(LIBS) $(DESTDIR)$(syslibdir)/$(LIBS)
- $(LN) $(LIBS) $(DESTDIR)$(syslibdir)/$(DEVLIB)
+ $(LN) $(DESTDIR)$(syslibdir)/$(LIBS) $(DESTDIR)$(syslibdir)/$(DEVLIB)
$(INSTALL_PROGRAM) -d $(DESTDIR)$(incdir)
$(INSTALL_PROGRAM) -m 644 mpath_cmd.h $(DESTDIR)$(incdir)
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 5/5] multipath-tools: add a link for libmultipath.so
2016-07-01 17:17 [PATCH 0/5] Makefiles housekeeping II Xose Vazquez Perez
` (3 preceding siblings ...)
2016-07-01 17:17 ` [PATCH 4/5] multipath-tools: link libmpathcmd.so with full path Xose Vazquez Perez
@ 2016-07-01 17:17 ` Xose Vazquez Perez
2016-07-08 7:16 ` [PATCH 0/5] Makefiles housekeeping II Christophe Varoqui
5 siblings, 0 replies; 9+ messages in thread
From: Xose Vazquez Perez @ 2016-07-01 17:17 UTC (permalink / raw)
Cc: device-mapper development, Xose Vazquez Perez
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
libmultipath/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libmultipath/Makefile b/libmultipath/Makefile
index de13e47..45c7ec9 100644
--- a/libmultipath/Makefile
+++ b/libmultipath/Makefile
@@ -63,9 +63,11 @@ install:
$(INSTALL_PROGRAM) -d $(DESTDIR)$(syslibdir)
$(INSTALL_PROGRAM) -m 755 $(LIBS) $(DESTDIR)$(syslibdir)/$(LIBS)
$(INSTALL_PROGRAM) -m 755 -d $(DESTDIR)$(libdir)
+ $(LN) $(DESTDIR)$(syslibdir)/$(LIBS) $(DESTDIR)$(syslibdir)/$(DEVLIB)
uninstall:
$(RM) $(DESTDIR)$(syslibdir)/$(LIBS)
+ $(RM) $(DESTDIR)$(syslibdir)/$(DEVLIB)
clean:
$(RM) core *.a *.o *.gz *.so *.so.*
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 0/5] Makefiles housekeeping II
2016-07-01 17:17 [PATCH 0/5] Makefiles housekeeping II Xose Vazquez Perez
` (4 preceding siblings ...)
2016-07-01 17:17 ` [PATCH 5/5] multipath-tools: add a link for libmultipath.so Xose Vazquez Perez
@ 2016-07-08 7:16 ` Christophe Varoqui
2016-07-08 13:02 ` Xose Vazquez Perez
5 siblings, 1 reply; 9+ messages in thread
From: Christophe Varoqui @ 2016-07-08 7:16 UTC (permalink / raw)
To: Xose Vazquez Perez; +Cc: device-mapper development
[-- Attachment #1.1: Type: text/plain, Size: 1378 bytes --]
Merged patches 1, 2 and 3 of this set.
I postponed merging the patches adding fullpath links in libs. Are you sure
it is best practice to use fullpaths there ?
Thanks.
On Fri, Jul 1, 2016 at 7:17 PM, Xose Vazquez Perez <xose.vazquez@gmail.com>
wrote:
> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> Cc: device-mapper development <dm-devel@redhat.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
>
> Xose Vazquez Perez (5):
> multipath-tools: replace rm with a variable in makefiles
> multipath-tools: replace install with its variable in makefiles
> multipath-tools: replace ln with a variable in makefiles
> multipath-tools: link libmpathcmd.so with full path
> multipath-tools: add a link for libmultipath.so
>
> Makefile.inc | 2 ++
> kpartx/Makefile | 12 ++++++------
> libmpathcmd/Makefile | 12 ++++++------
> libmpathpersist/Makefile | 28 ++++++++++++++--------------
> libmultipath/Makefile | 8 +++++---
> libmultipath/checkers/Makefile | 4 ++--
> libmultipath/prioritizers/Makefile | 4 ++--
> mpathpersist/Makefile | 16 ++++++++--------
> multipath/Makefile | 12 ++++++------
> multipathd/Makefile | 10 +++++-----
> 10 files changed, 56 insertions(+), 52 deletions(-)
>
> --
> 2.7.4
>
>
[-- Attachment #1.2: Type: text/html, Size: 2105 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 0/5] Makefiles housekeeping II
2016-07-08 7:16 ` [PATCH 0/5] Makefiles housekeeping II Christophe Varoqui
@ 2016-07-08 13:02 ` Xose Vazquez Perez
2016-07-08 13:17 ` Christophe Varoqui
0 siblings, 1 reply; 9+ messages in thread
From: Xose Vazquez Perez @ 2016-07-08 13:02 UTC (permalink / raw)
To: Christophe Varoqui; +Cc: device-mapper development
On 07/08/2016 09:16 AM, Christophe Varoqui wrote:
> Merged patches 1, 2 and 3 of this set.
>
> I postponed merging the patches adding fullpath links in libs.
> Are you sure it is best practice to use fullpaths there ?
This is up to you. It works as is.
But in "libmpathpersist/Makefile" is done as in my patch:
$ git grep '$(LN) $(DESTDIR)$(syslibdir)/$(LIBS) $(DESTDIR)$(syslibdir)/$(DEVLIB)'
libmpathpersist/Makefile: $(LN) $(DESTDIR)$(syslibdir)/$(LIBS) $(DESTDIR)$(syslibdir)/$(DEVLIB)
Let me know your preference.
^ permalink raw reply [flat|nested] 9+ messages in thread