dm-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Xose Vazquez Perez <xose.vazquez@gmail.com>
Cc: device-mapper development <dm-devel@redhat.com>,
	Xose Vazquez Perez <xose.vazquez@gmail.com>
Subject: [PATCH 06/11] multipath-tools: request to update man pages if the code is changed
Date: Thu, 11 Aug 2016 20:32:22 +0200	[thread overview]
Message-ID: <1470940345-4441-6-git-send-email-xose.vazquez@gmail.com> (raw)
In-Reply-To: <1470940345-4441-1-git-send-email-xose.vazquez@gmail.com>

Please, document the changes.

Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/checkers/Makefile     | 1 +
 libmultipath/defaults.h            | 4 ++++
 libmultipath/dict.c                | 3 +++
 libmultipath/prioritizers/Makefile | 1 +
 4 files changed, 9 insertions(+)

diff --git a/libmultipath/checkers/Makefile b/libmultipath/checkers/Makefile
index e46192c..11ab76f 100644
--- a/libmultipath/checkers/Makefile
+++ b/libmultipath/checkers/Makefile
@@ -5,6 +5,7 @@ include ../../Makefile.inc
 
 CFLAGS += -I..
 
+# If you add or remove a checker also update multipath/multipath.conf.5
 LIBS= \
 	libcheckcciss_tur.so \
 	libcheckreadsector0.so \
diff --git a/libmultipath/defaults.h b/libmultipath/defaults.h
index dd6a24b..3af85eb 100644
--- a/libmultipath/defaults.h
+++ b/libmultipath/defaults.h
@@ -1,3 +1,7 @@
+/*
+ * If you add or modify a value also update multipath/multipath.conf.5
+ * and the TEMPLATE in libmultipath/hwtable.c
+ */
 #define DEFAULT_UID_ATTRIBUTE	"ID_SERIAL"
 #define DEFAULT_UDEVDIR		"/dev"
 #define DEFAULT_MULTIPATHDIR	"/" LIB_STRING "/multipath"
diff --git a/libmultipath/dict.c b/libmultipath/dict.c
index 1933b6d..e8c6804 100644
--- a/libmultipath/dict.c
+++ b/libmultipath/dict.c
@@ -1329,6 +1329,9 @@ snprint_deprecated (struct config *conf, char * buff, int len, void * data)
 
 #define __deprecated
 
+/*
+ * If you add or remove a keywork also update multipath/multipath.conf.5
+ */
 void
 init_keywords(vector keywords)
 {
diff --git a/libmultipath/prioritizers/Makefile b/libmultipath/prioritizers/Makefile
index eff5fc1..36b42e4 100644
--- a/libmultipath/prioritizers/Makefile
+++ b/libmultipath/prioritizers/Makefile
@@ -5,6 +5,7 @@ include ../../Makefile.inc
 
 CFLAGS += -I..
 
+# If you add or remove a prioritizer also update multipath/multipath.conf.5
 LIBS = \
 	libprioalua.so \
 	libprioconst.so \
-- 
2.7.4

  parent reply	other threads:[~2016-08-11 18:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-11 18:32 [PATCH 01/11] multipath-tools: add support for all IBM Enterprise Storage Server / Shark family Xose Vazquez Perez
2016-08-11 18:32 ` [PATCH 02/11] multipath-tools: minor edit of multipath/multipath.conf.5 Xose Vazquez Perez
2016-08-11 18:32 ` [PATCH 03/11] multipath-tools: Makefiles housekeeping Xose Vazquez Perez
2016-08-11 18:32 ` [PATCH 04/11] multipath-tools: Edward Goggin no longer works at EMC Xose Vazquez Perez
2016-08-11 18:32 ` [PATCH 05/11] multipath-tools: delete IBM/1745 ghost array Xose Vazquez Perez
2016-08-11 18:32 ` Xose Vazquez Perez [this message]
2016-08-11 18:32 ` [PATCH 07/11] multipath-tools: move DEFAULT_PRIO DEFAULT_PRIO_ARGS and DEFAULT_CHECKER to libmultipath/defaults.h Xose Vazquez Perez
2016-08-11 18:32 ` [PATCH 08/11] multipath-tools: add KOVE/XPD to hwtable Xose Vazquez Perez
2016-08-11 18:32 ` [PATCH 09/11] multipath-tools: delete failback from IBM/2810XIV Xose Vazquez Perez
2016-08-16  7:50 ` [PATCH 01/11] multipath-tools: add support for all IBM Enterprise Storage Server / Shark family Christophe Varoqui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1470940345-4441-6-git-send-email-xose.vazquez@gmail.com \
    --to=xose.vazquez@gmail.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).