From: "Benjamin Marzinski" <bmarzins@redhat.com>
To: device-mapper development <dm-devel@redhat.com>
Subject: [PATCH 03/10] do not allow in-use path to change wwid
Date: Fri, 28 Oct 2016 21:55:19 -0500 [thread overview]
Message-ID: <1477709726-5442-4-git-send-email-bmarzins@redhat.com> (raw)
In-Reply-To: <1477709726-5442-1-git-send-email-bmarzins@redhat.com>
When a path is part of a multipath device, it must not change it's wwid.
If it can, when multipathd is reconfigured, you can end up with two
multipath devices owning the same path, eventually leading to a crash.
Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
---
libmultipath/dmparser.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/libmultipath/dmparser.c b/libmultipath/dmparser.c
index 9e79ecd..87e8398 100644
--- a/libmultipath/dmparser.c
+++ b/libmultipath/dmparser.c
@@ -380,6 +380,14 @@ disassemble_map (vector pathvec, char * params, struct multipath * mpp,
strncpy(pp->wwid, mpp->wwid,
WWID_SIZE - 1);
+ /*
+ * Do not allow in-use patch to change wwid
+ */
+ else if (strcmp(pp->wwid, mpp->wwid) != 0) {
+ condlog(0, "%s: path wwid appears to have changed. Using map wwid.\n", pp->dev_t);
+ strncpy(pp->wwid, mpp->wwid, WWID_SIZE);
+ }
+
pgp->id ^= (long)pp;
pp->pgindex = i + 1;
--
1.8.3.1
next prev parent reply other threads:[~2016-10-29 2:55 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-29 2:55 [PATCH 00/10] misc. multipath patches Benjamin Marzinski
2016-10-29 2:55 ` [PATCH 01/10] libmultipath: add skip_kpartx option Benjamin Marzinski
2016-10-30 13:42 ` Hannes Reinecke
2016-10-29 2:55 ` [PATCH 02/10] kpartx.rules: respect skip_kpartx flag Benjamin Marzinski
2016-10-30 13:42 ` Hannes Reinecke
2016-10-29 2:55 ` Benjamin Marzinski [this message]
2016-10-30 13:45 ` [PATCH 03/10] do not allow in-use path to change wwid Hannes Reinecke
2016-10-31 14:30 ` Benjamin Marzinski
2016-10-29 2:55 ` [PATCH 04/10] multipathd: add "map failures" format wildcard Benjamin Marzinski
2016-10-30 13:45 ` Hannes Reinecke
2016-10-29 2:55 ` [PATCH 05/10] mpath: don't wait for udev if all paths are down Benjamin Marzinski
2016-10-30 13:46 ` Hannes Reinecke
2016-10-29 2:55 ` [PATCH 06/10] multipath: set cookie before using it Benjamin Marzinski
2016-10-30 13:46 ` Hannes Reinecke
2016-10-29 2:55 ` [PATCH 07/10] recover from errors in multipathd startup Benjamin Marzinski
2016-10-30 13:47 ` Hannes Reinecke
2016-10-29 2:55 ` [PATCH 08/10] fix INIT_REQUESTED_UDEV code Benjamin Marzinski
2016-10-30 13:48 ` Hannes Reinecke
2016-10-29 2:55 ` [PATCH 09/10] add disable_changed_wwids option Benjamin Marzinski
2016-10-30 13:54 ` Hannes Reinecke
2016-11-04 15:32 ` Benjamin Marzinski
2017-02-28 12:27 ` Zhangguanghui
2016-11-06 0:03 ` Xose Vazquez Perez
2016-11-07 14:47 ` Benjamin Marzinski
2016-10-29 2:55 ` [PATCH 10/10] set retrigger_tries to 0 for multipath Benjamin Marzinski
2016-10-30 13:54 ` Hannes Reinecke
2016-12-06 15:11 ` Xose Vazquez Perez
2016-12-06 15:22 ` Benjamin Marzinski
2017-04-25 14:07 ` Xose Vazquez Perez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477709726-5442-4-git-send-email-bmarzins@redhat.com \
--to=bmarzins@redhat.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).