Linux Device Mapper development
 help / color / mirror / Atom feed
From: "Benjamin Marzinski" <bmarzins@redhat.com>
To: device-mapper development <dm-devel@redhat.com>
Subject: [PATCH v3 4/7] multipathd: don't update priority of failed paths
Date: Tue, 14 Feb 2017 20:16:54 -0600	[thread overview]
Message-ID: <1487125017-22049-5-git-send-email-bmarzins@redhat.com> (raw)
In-Reply-To: <1487125017-22049-1-git-send-email-bmarzins@redhat.com>

Multipathd shouldn't be updating the priority of failed paths in the
checkerloop. The current avoids this in almost all cases, but not all.
Close the loophole.

Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
---
 multipathd/main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/multipathd/main.c b/multipathd/main.c
index adc3258..5480e96 100644
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -1457,7 +1457,8 @@ int update_prio(struct path *pp, int refresh_all)
 	}
 	oldpriority = pp->priority;
 	conf = get_multipath_config();
-	pathinfo(pp, conf, DI_PRIO);
+	if (pp->state != PATH_DOWN)
+		pathinfo(pp, conf, DI_PRIO);
 	put_multipath_config(conf);
 
 	if (pp->priority == oldpriority)
-- 
1.8.3.1

  parent reply	other threads:[~2017-02-15  2:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-15  2:16 [PATCH v3 0/7] misc patches Benjamin Marzinski
2017-02-15  2:16 ` [PATCH v3 1/7] kpartx: don't keep creating recursive partitions Benjamin Marzinski
2017-02-27  6:03   ` Christophe Varoqui
2017-02-15  2:16 ` [PATCH v3 2/7] libmultipath: add detect_checker option Benjamin Marzinski
2017-02-20 11:38   ` Martin Wilck
2017-02-15  2:16 ` [PATCH v3 3/7] libmultipath: cleanup orphan device states Benjamin Marzinski
2017-02-15  2:16 ` Benjamin Marzinski [this message]
2017-02-15  2:16 ` [PATCH v3 5/7] multipathd: add messages on delayed path addition Benjamin Marzinski
2017-02-15  2:16 ` [PATCH v3 6/7] multipathd: allow resetting stats Benjamin Marzinski
2017-02-15  2:16 ` [PATCH v3 7/7] fix udev rules for failed multipath devices Benjamin Marzinski
2017-02-27  6:09 ` [PATCH v3 0/7] misc patches Christophe Varoqui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1487125017-22049-5-git-send-email-bmarzins@redhat.com \
    --to=bmarzins@redhat.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox