Linux Device Mapper development
 help / color / mirror / Atom feed
From: Martin Wilck <mwilck@suse.com>
To: dm-devel@redhat.com, Ritika Srivastava <ritika.srivastava@oracle.com>
Cc: Martin Wilck <mwilck@suse.de>
Subject: Re: [PATCH 1/1] multipath-tools: Skip CHANGE uevent for non-mpath devices
Date: Sat, 07 Oct 2017 01:20:18 +0200	[thread overview]
Message-ID: <1507332018.17546.1.camel@suse.com> (raw)
In-Reply-To: <1507321967-12942-1-git-send-email-ritika.srivastava@oracle.com>

On Fri, 2017-10-06 at 13:32 -0700, Ritika Srivastava wrote:
> On removal of lv device snapshot using lvremove, CHANGE uevent and
> REMOVE uevent is generated for the dm device.
> When multipath tries to process the CHANGE uevent, it is not able to
> find the dm/map name and
> returns 1 due to which the following error is printed
> "uevent trigger error"
> This scenario is not actually an error and is misleading.
> 
> To fix it, the proposal is to only process the change uevent in
> multipath for a multipath device.
> 
> Signed-off-by: Ritika Srivastava <ritika.srivastava@oracle.com>

OK, but IMO it could be done more nicely. I'll post an alternative
patch soon.

Regards,
Martin

-- 
Dr. Martin Wilck <mwilck@suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

      reply	other threads:[~2017-10-06 23:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-06 20:32 [PATCH 1/1] multipath-tools: Skip CHANGE uevent for non-mpath devices Ritika Srivastava
2017-10-06 23:20 ` Martin Wilck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1507332018.17546.1.camel@suse.com \
    --to=mwilck@suse.com \
    --cc=dm-devel@redhat.com \
    --cc=mwilck@suse.de \
    --cc=ritika.srivastava@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox