dm-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
* Re: multipath-tools: add INSPUR/MCS to hardware table
@ 2018-01-29  6:04 Tom Geng(耿芳忠)
  2018-01-29 13:37 ` Martin Wilck
  2018-01-30 18:13 ` Xose Vazquez Perez
  0 siblings, 2 replies; 10+ messages in thread
From: Tom Geng(耿芳忠) @ 2018-01-29  6:04 UTC (permalink / raw)
  To: xose.vazquez@gmail.com; +Cc: dm-devel@redhat.com


[-- Attachment #1.1: Type: text/plain, Size: 992 bytes --]

Hi, Xose,
I sent the patch to dm-devel last week, but forgot to CC you. Please help to 
review and have chance to submit to the mainline.
Thank you a lot.


From 091bae5fec22c61f0c3e6f9ab848fecae5203122 Mon Sep 17 00:00:00 2001
From: Tom Geng <gengfangzhong@inspur.com>
Date: Tue, 23 Jan 2018 15:33:09 +0800
Subject: [PATCH] multipath-tools: add INSPUR/MCS to hardware table

---
 libmultipath/hwtable.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 448effe3..93d67df0 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -1181,6 +1181,17 @@ static struct hwentry default_hw[] = {
 		.pgpolicy      = MULTIBUS,
 		.no_path_retry = 30,
 	},
+	/*
+	 * INSPUR
+	 */
+	{
+		/* AS5300/AS5500 G2 */
+		.vendor        = "INSPUR",
+		.product       = "MCS",
+		.pgpolicy      = GROUP_BY_PRIO,
+		.pgfailback    = -FAILBACK_IMMEDIATE,
+		.prio_name     = PRIO_ALUA,
+	},
 	/*
 	 * EOL
 	 */
-- 
2.15.1.windows.2


[-- Attachment #1.2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 4108 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: multipath-tools: add INSPUR/MCS to hardware table
@ 2018-01-23 11:01 Tom Geng(耿芳忠)
  0 siblings, 0 replies; 10+ messages in thread
From: Tom Geng(耿芳忠) @ 2018-01-23 11:01 UTC (permalink / raw)
  To: dm-devel@redhat.com


[-- Attachment #1.1.1: Type: text/plain, Size: 1008 bytes --]

Hi, Xose,
Thank you for your review work and suggestions. Attachment is the patch file
generated by git format-patch, and pasted below. Please help to submit,
thank you.


From 091bae5fec22c61f0c3e6f9ab848fecae5203122 Mon Sep 17 00:00:00 2001
From: Tom Geng <gengfangzhong@inspur.com>
Date: Tue, 23 Jan 2018 15:33:09 +0800
Subject: [PATCH] multipath-tools: add INSPUR/MCS to hardware table

---
 libmultipath/hwtable.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 448effe3..93d67df0 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -1181,6 +1181,17 @@ static struct hwentry default_hw[] = {
 		.pgpolicy      = MULTIBUS,
 		.no_path_retry = 30,
 	},
+	/*
+	 * INSPUR
+	 */
+	{
+		/* AS5300/AS5500 G2 */
+		.vendor        = "INSPUR",
+		.product       = "MCS",
+		.pgpolicy      = GROUP_BY_PRIO,
+		.pgfailback    = -FAILBACK_IMMEDIATE,
+		.prio_name     = PRIO_ALUA,
+	},
 	/*
 	 * EOL
 	 */
-- 
2.15.1.windows.2



[-- Attachment #1.1.2: 0001-multipath-tools-add-INSPUR-MCS-to-hardware-table.patch --]
[-- Type: application/octet-stream, Size: 869 bytes --]

From 091bae5fec22c61f0c3e6f9ab848fecae5203122 Mon Sep 17 00:00:00 2001
From: Tom Geng <gengfangzhong@inspur.com>
Date: Tue, 23 Jan 2018 15:33:09 +0800
Subject: [PATCH] multipath-tools: add INSPUR/MCS to hardware table

---
 libmultipath/hwtable.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 448effe3..93d67df0 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -1181,6 +1181,17 @@ static struct hwentry default_hw[] = {
 		.pgpolicy      = MULTIBUS,
 		.no_path_retry = 30,
 	},
+	/*
+	 * INSPUR
+	 */
+	{
+		/* AS5300/AS5500 G2 */
+		.vendor        = "INSPUR",
+		.product       = "MCS",
+		.pgpolicy      = GROUP_BY_PRIO,
+		.pgfailback    = -FAILBACK_IMMEDIATE,
+		.prio_name     = PRIO_ALUA,
+	},
 	/*
 	 * EOL
 	 */
-- 
2.15.1.windows.2


[-- Attachment #1.2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 4108 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply related	[flat|nested] 10+ messages in thread
* multipath-tools: add INSPUR/MCS to hardware table
@ 2018-01-22 10:55 Tom Geng(耿芳忠)
  2018-01-22 14:44 ` Xose Vazquez Perez
  0 siblings, 1 reply; 10+ messages in thread
From: Tom Geng(耿芳忠) @ 2018-01-22 10:55 UTC (permalink / raw)
  To: dm-devel@redhat.com


[-- Attachment #1.1.1: Type: text/plain, Size: 2209 bytes --]

Hi, everybody,

I added a new device support, the history and code diff is as below, will
the maintainers help to review and submit? 

Thank you a lot.

 

 

$ git log

commit f7bec5ee939ffff079cc01f8a09e7e51e4b26365 (HEAD -> master, develop)

Author: Tom Geng <gengfangzhong@inspur.com>

Date:   Fri Jan 19 10:25:11 2018 +0800

 

        multipath-tools: add new device, product name is INSPUR
AS5300/AS5500 G2.

 

        It's dual-controller, Active-Active mode, and SPC-3 ALUA feature

        support.

 

        Signed-off-by: Tom Geng <gengfangzhong@inspur.com>

 

commit 07e7bd579ea22e3de0f6481643e9b0809cd76210 (origin/master, origin/HEAD)

Author: Benjamin Marzinski <bmarzins@redhat.com>

Date:   Wed Dec 13 12:08:07 2017 -0600

 

    libmultipath: don't update path queueing on reload

 

    With the fix to the features handling code, the multipath device should

    already be reloaded with the correct value for queue_if_no_path, so

    there's no need to go reset it immediately afterwards.

 

    Cc: Martin Wilck <mwilck@suse.com>

    Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>

 

commit 7e7441e9f0127e0bcf23771955ab829f489641fe

Author: Benjamin Marzinski <bmarzins@redhat.com>

Date:   Thu Dec 7 12:49:06 2017 -0600

 

    multipathd: marginal path code fixes

 

 

 

$ git diff f7bec5e..07e7bd5

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c

index c8acf3af..448effe3 100644

--- a/libmultipath/hwtable.c

+++ b/libmultipath/hwtable.c

@@ -1181,21 +1181,6 @@ static struct hwentry default_hw[] = {

                .pgpolicy      = MULTIBUS,

                .no_path_retry = 30,

        },

-       /*

-        * INSPUR

-        *

-        * Maintainer: Tom Geng

-        * Mail: gengfangzhong@inspur.com

-        */

-       {

-               /* AS5300/AS5500 G2 */

-               .vendor        = "INSPUR",

-               .product       = "MCS",

-               .pgpolicy      = GROUP_BY_PRIO,

-               .selector      = "round-robin 0",

-               .pgfailback    = -FAILBACK_IMMEDIATE,

-               .prio_name     = PRIO_ALUA,

-       },

        /*

         * EOL

         */

 

 

Tom Geng

2018.01.22

 


[-- Attachment #1.1.2: Type: text/html, Size: 17054 bytes --]

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 4108 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2018-01-30 18:13 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-29  6:04 multipath-tools: add INSPUR/MCS to hardware table Tom Geng(耿芳忠)
2018-01-29 13:37 ` Martin Wilck
2018-01-30  1:54   ` Tom Geng(耿芳忠)
2018-01-30  7:33     ` Martin Wilck
2018-01-30 13:58   ` Xose Vazquez Perez
2018-01-30 14:05     ` Martin Wilck
2018-01-30 18:13 ` Xose Vazquez Perez
  -- strict thread matches above, loose matches on Subject: below --
2018-01-23 11:01 Tom Geng(耿芳忠)
2018-01-22 10:55 Tom Geng(耿芳忠)
2018-01-22 14:44 ` Xose Vazquez Perez

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).