Re: [PATCH 2/7] multipath: fix DEF_TIMEOUT use

From: Martin Wilck <mwilck@suse.com>
To: Benjamin Marzinski <bmarzins@redhat.com>,
	device-mapper development <dm-devel@redhat.com>
Subject: Re: [PATCH 2/7] multipath: fix DEF_TIMEOUT use
Date: Thu, 08 Feb 2018 09:52:16 +0100	[thread overview]
Message-ID: <1518079936.15245.40.camel@suse.com> (raw)
In-Reply-To: <1518043787-7066-3-git-send-email-bmarzins@redhat.com>

On Wed, 2018-02-07 at 16:49 -0600, Benjamin Marzinski wrote:
> DEF_TIMEOUT is specified in seconds. The io_hdr timeout is specified
> in
> milliseconds, so we need to convert it. Multipath should be waiting
> longer than 30 milliseconds here. If there are concerns that 30
> seconds
> may be too long, we could always make this configurable, using
> conf->checker_timeout if set.
> 
> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
> ---
>  libmultipath/discovery.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Martin Wilck <mwilck@suse.com>

> 
> diff --git a/libmultipath/discovery.c b/libmultipath/discovery.c
> index 4b31dde..f118800 100644
> --- a/libmultipath/discovery.c
> +++ b/libmultipath/discovery.c
> @@ -766,7 +766,7 @@ do_inq(int sg_fd, int cmddt, int evpd, unsigned
> int pg_op,
>  	io_hdr.dxferp = resp;
>  	io_hdr.cmdp = inqCmdBlk;
>  	io_hdr.sbp = sense_b;
> -	io_hdr.timeout = DEF_TIMEOUT;
> +	io_hdr.timeout = DEF_TIMEOUT * 1000;
>  
>  	if (ioctl(sg_fd, SG_IO, &io_hdr) < 0)
>  		return -1;

-- 
Dr. Martin Wilck <mwilck@suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel