From: Martin Wilck <mwilck@suse.com>
To: Chongyun Wu <wu.chongyun@h3c.com>,
"dm-devel@redhat.com" <dm-devel@redhat.com>
Cc: Guozhonghua <guozhonghua@h3c.com>,
Changwei Ge <ge.changwei@h3c.com>,
Changlimin <changlimin@h3c.com>
Subject: Re: [PATCH] multipathd: add lock protection for cli_list_status
Date: Mon, 26 Feb 2018 14:52:12 +0100 [thread overview]
Message-ID: <1519653132.4661.45.camel@suse.com> (raw)
In-Reply-To: <CEB9978CF3252343BE3C67AC9F0086A34295B3BB@H3CMLB14-EX.srv.huawei-3com.com>
On Fri, 2018-02-23 at 09:58 +0000, Chongyun Wu wrote:
> cli_list_status will access vecs->pathvec which should have lock
> protection, otherwise might get inconsistent data or other
> problem.
>
> Signed-off-by: Chongyun Wu <wu.chongyun@h3c.com>
Reviewed-by: Martin Wilck <mwilck@suse.com>
> ---
> multipathd/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/multipathd/main.c b/multipathd/main.c
> index e74a448..b4e15eb 100644
> --- a/multipathd/main.c
> +++ b/multipathd/main.c
> @@ -1204,7 +1204,7 @@ uxlsnrloop (void * ap)
> set_handler_callback(LIST+PATHS+RAW+FMT,
> cli_list_paths_raw);
> set_handler_callback(LIST+PATH, cli_list_path);
> set_handler_callback(LIST+MAPS, cli_list_maps);
> - set_unlocked_handler_callback(LIST+STATUS, cli_list_status);
> + set_handler_callback(LIST+STATUS, cli_list_status);
> set_unlocked_handler_callback(LIST+DAEMON,
> cli_list_daemon);
> set_handler_callback(LIST+MAPS+STATUS,
> cli_list_maps_status);
> set_handler_callback(LIST+MAPS+STATS, cli_list_maps_stats);
--
Dr. Martin Wilck <mwilck@suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
prev parent reply other threads:[~2018-02-26 13:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 9:58 [PATCH] multipathd: add lock protection for cli_list_status Chongyun Wu
2018-02-26 13:52 ` Martin Wilck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519653132.4661.45.camel@suse.com \
--to=mwilck@suse.com \
--cc=changlimin@h3c.com \
--cc=dm-devel@redhat.com \
--cc=ge.changwei@h3c.com \
--cc=guozhonghua@h3c.com \
--cc=wu.chongyun@h3c.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox