From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "xose.vazquez@gmail.com" <xose.vazquez@gmail.com>
Cc: "dm-devel@redhat.com" <dm-devel@redhat.com>
Subject: Re: [PATCH] multipath-tools: Remove trailing/leading whitespaces and reformat code
Date: Fri, 9 Mar 2018 22:04:08 +0000 [thread overview]
Message-ID: <1520633047.2907.14.camel@wdc.com> (raw)
In-Reply-To: <20180309220053.3022-1-xose.vazquez@gmail.com>
On Fri, 2018-03-09 at 23:00 +0100, Xose Vazquez Perez wrote:
> # Check whether a function with name $1 has been declared in header file $2.
> -check_func = \
> - $(shell \
> +check_func = $(shell \
> if grep -Eq "^[^[:blank:]]+[[:blank:]]+$1[[:blank:]]*(.*)*" "$2"; then \
> - found=1; \
> - status="yes"; \
> - else \
> - found=0; \
> - status="no"; \
> - fi; \
> - echo 1>&2 "Checking for $1 in $2 ... $$status"; \
> - echo "$$found" \
> - )
> + found=1; \
> + status="yes"; \
> + else \
> + found=0; \
> + status="no"; \
> + fi; \
> + echo 1>&2 "Checking for $1 in $2 ... $$status"; \
> + echo "$$found" \
> + )
Whitespace-only patches are not useful, and on top of that you are making the code
much more ugly by breaking the alignment of the trailing backslahes. Yikes!
Bart.
next prev parent reply other threads:[~2018-03-09 22:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 22:00 [PATCH] multipath-tools: Remove trailing/leading whitespaces and reformat code Xose Vazquez Perez
2018-03-09 22:04 ` Bart Van Assche [this message]
2018-03-09 22:09 ` Xose Vazquez Perez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520633047.2907.14.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=dm-devel@redhat.com \
--cc=xose.vazquez@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox