From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: Revert "dm mpath: remove unnecessary NVMe branching in favor of scsi_dh checks" Date: Tue, 13 Mar 2018 16:46:10 +0000 Message-ID: <1520959569.2638.19.camel@wdc.com> References: <20180312202808.3556-1-bart.vanassche@wdc.com> <20180312212314.GA30763@redhat.com> <1520890358.3469.68.camel@wdc.com> <20180313152551.GA2785@redhat.com> <20180313163135.GB2785@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180313163135.GB2785@redhat.com> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: "snitzer@redhat.com" Cc: "dm-devel@redhat.com" List-Id: dm-devel.ids On Tue, 2018-03-13 at 12:31 -0400, Mike Snitzer wrote: > But now I cannot get the test to run: > > # srp-test/run_tests -c -d -r 10 -t 02-mq > Unloaded the ib_srpt kernel module > Unloaded the rdma_rxe kernel module > SoftRoCE network interfaces: rxe0 rxe1 rxe2 rxe3 > Zero-initializing /dev/ram0 ... done > Zero-initializing /dev/ram1 ... done > Configured SRP target driver > Running test srp-test/tests/02-mq ... > Test file I/O on top of multipath concurrently with logout and login (0 min; mq) > Unloaded the ib_srp kernel module > /dev/disk/by-id/dm-uuid-mpath-3600140572616d6469736b31000000000: not found > Test srp-test/tests/02-mq failed > > [ 379.634518] ib_srp: QP creation failed for dev rxe1: -22 > [ 379.639849] srpt/10.16.43.122: Unsupported SCSI Opcode 0xa3, sending CHECK_CONDITION. > [ 379.665891] sd 7:0:0:1: [sdk] Attached SCSI disk > [ 379.673312] ib_srp: QP creation failed for dev rxe2: -22 > [ 379.688331] ib_srp: QP creation failed for dev rxe3: -22 > [ 379.708324] ib_srp: bad dest parameter '[2620:52:0:102f:219:99ff:feb7:2648' > [ 379.724538] ib_srp: target creation request is missing one or more parameters > [ 379.740253] ib_srp: bad dest parameter '[2620:52:0:102f:219:99ff:feb7:2648' > [ 379.756531] ib_srp: target creation request is missing one or more parameters > [ 379.773242] ib_srp: bad dest parameter '[2620:52:0:102f:219:99ff:feb7:2648' > [ 379.789532] ib_srp: target creation request is missing one or more parameters > [ 379.805255] ib_srp: bad dest parameter '[2620:52:0:102f:219:99ff:feb7:2648' > [ 379.822532] ib_srp: target creation request is missing one or more parameters That's weird. I will see whether I can reproduce this with linux-next, since I have not yet tried to run srp-test against linux-next myself. > But I realized that was with an old srp-test build.. so I tried to make > again.. seems your buildrequires has expanded: > > Why does it need shellcheck? On RHEL, having to pull in EPEL packages sucks. Shellcheck is only required for someone who wants to edit the srp-test scripts and who wants to verify these scripts with shellcheck. Shellcheck is not needed to run the srp-test scripts. Bart.