From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Benjamin Marzinski" Subject: [PATCH v3 16/19] multipathd: remove useless check and fix format Date: Fri, 21 Sep 2018 18:05:24 -0500 Message-ID: <1537571127-10143-17-git-send-email-bmarzins@redhat.com> References: <1537571127-10143-1-git-send-email-bmarzins@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1537571127-10143-1-git-send-email-bmarzins@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: device-mapper development Cc: Martin Wilck List-Id: dm-devel.ids The only thing this patch changes is to remove the check for pp->mpp before the check for pp->mpp->prflags, since check_path() already verified that pp->mpp != NULL. This fixes a number of coverity warnings. Also, I normalized the spacing and indenting of the nearby code. Signed-off-by: Benjamin Marzinski --- multipathd/main.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/multipathd/main.c b/multipathd/main.c index 125a805..3c2fe7b 100644 --- a/multipathd/main.c +++ b/multipathd/main.c @@ -1978,14 +1978,14 @@ check_path (struct vectors * vecs, struct path * pp, int ticks) return 1; } - if(newstate == PATH_UP || newstate == PATH_GHOST){ - if ( pp->mpp && pp->mpp->prflag ){ + if (newstate == PATH_UP || newstate == PATH_GHOST) { + if (pp->mpp->prflag) { /* * Check Persistent Reservation. */ - condlog(2, "%s: checking persistent reservation " - "registration", pp->dev); - mpath_pr_event_handle(pp); + condlog(2, "%s: checking persistent " + "reservation registration", pp->dev); + mpath_pr_event_handle(pp); } } -- 2.7.4