Linux Device Mapper development
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Mikulas Patocka <mpatocka@redhat.com>,
	Milan Broz <mbroz@redhat.com>, Mike Snitzer <msnitzer@redhat.com>,
	Ming Lei <minlei@redhat.com>
Cc: dm-devel@redhat.com
Subject: Re: [PATCH] dm: don't overallocate the tags space
Date: Fri, 08 Feb 2019 07:58:12 -0800	[thread overview]
Message-ID: <1549641492.34241.81.camel@acm.org> (raw)
In-Reply-To: <alpine.LRH.2.02.1902081048510.1182@file01.intranet.prod.int.rdu2.redhat.com>

On Fri, 2019-02-08 at 10:52 -0500, Mikulas Patocka wrote:
> bio_sectors returns the value in the units of 512-byte sectors (no matter
> what's the real sector size of the device). dm-crypt multiplies
> bio_sectors by on_disk_tag_size to calculate the space allocated for
> integrity tags. If dm-crypt is running with sector size larger than 512,
> it allocates more data than what's needed.
> 
> Device mapper trimmed this extra space when passing the bio to
> dm-integrity, so this bug didn't result in any visible misbehavior. This
> bug showed up when device mapper stopped trimming the bio.
> 
> Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
> Reported-by: Milan Broz <mbroz@redhat.com>

Hi Mikulas,

Is this a fix for commit fa8db4948f52 ("dm: don't use bio_trim() afterall")?
If so, please consider adding a "Fixes:" tag.

Thanks,

Bart.

  reply	other threads:[~2019-02-08 15:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-08 15:52 [PATCH] dm: don't overallocate the tags space Mikulas Patocka
2019-02-08 15:58 ` Bart Van Assche [this message]
2019-02-08 16:02   ` Mike Snitzer
2019-02-08 18:06 ` [PATCH] " Milan Broz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1549641492.34241.81.camel@acm.org \
    --to=bvanassche@acm.org \
    --cc=dm-devel@redhat.com \
    --cc=mbroz@redhat.com \
    --cc=minlei@redhat.com \
    --cc=mpatocka@redhat.com \
    --cc=msnitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox