Linux Device Mapper development
 help / color / mirror / Atom feed
From: Milan Broz <gmazyland@gmail.com>
To: Mikulas Patocka <mpatocka@redhat.com>, Milan Broz <gmazyland@gmail.com>
Cc: dm-devel@redhat.com, snitzer@redhat.com
Subject: Re: [RFC PATCH] dm: Check for device sector overflow if CONFIG_LBDAF is not set
Date: Mon, 5 Nov 2018 19:59:25 +0100	[thread overview]
Message-ID: <178d2361-8d31-ae07-a1ca-59889193e3ce@gmail.com> (raw)
In-Reply-To: <alpine.LRH.2.02.1811051333580.28808@file01.intranet.prod.int.rdu2.redhat.com>

On 05/11/2018 19:35, Mikulas Patocka wrote:
> But the condition "sizeof(cc->start) < sizeof(tmpll)" could be dropped, 
> the compiler will optimize out "cc->start != tmpll" if the types have the 
> same width.

Yes, the intention here is that in 64bit env. the whole if condition
is not compiled in. If it happens without "sizeof(cc->start) < sizeof(tmpll)",
then we can drop it.

So, does it make sense to add this to all dm targets? Or any better idea?

Milan

  reply	other threads:[~2018-11-05 18:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-04 13:42 [RFC PATCH] dm: Check for device sector overflow if CONFIG_LBDAF is not set Milan Broz
2018-11-05 18:35 ` Mikulas Patocka
2018-11-05 18:59   ` Milan Broz [this message]
2018-11-06 21:44     ` Mikulas Patocka
2018-11-07 21:24       ` [PATCH v2] " Milan Broz
2018-11-15 13:20         ` Mikulas Patocka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178d2361-8d31-ae07-a1ca-59889193e3ce@gmail.com \
    --to=gmazyland@gmail.com \
    --cc=dm-devel@redhat.com \
    --cc=mpatocka@redhat.com \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox