From: Mikulas Patocka <mpatocka@redhat.com>
To: Mike Snitzer <snitzer@kernel.org>
Cc: Benjamin Marzinski <bmarzins@redhat.com>,
Mike Snitzer <snitzer@redhat.com>,
dm-devel@lists.linux.dev
Subject: Re: dm-table: fix checking for rq stackable devices
Date: Mon, 23 Jun 2025 11:59:10 +0200 (CEST) [thread overview]
Message-ID: <1ca5ff9e-5e48-4909-7cef-1090c83c882f@redhat.com> (raw)
In-Reply-To: <aFHze2MNk1LU1_13@kernel.org>
On Tue, 17 Jun 2025, Mike Snitzer wrote:
> On Fri, Jun 13, 2025 at 07:08:52PM -0400, Benjamin Marzinski wrote:
> > Due to the semantics of iterate_devices(), the current code allows a
> > request-based dm table as long as it includes one request-stackable
> > device. It is supposed to only allow tables where there are no
> > non-request-stackable devices.
> >
> > Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
>
> Amazing this type of bug is still lurking, thought I audited all of
> the iterate_devices callout functions.. anyway, thanks for fixing it!
>
> Reviewed-by: Mike Snitzer <snitzer@kernel.org>
I've applied the patch, thanks.
Mikulas
prev parent reply other threads:[~2025-06-23 9:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 23:08 [PATCH] dm-table: fix checking for rq stackable devices Benjamin Marzinski
2025-06-17 23:00 ` Mike Snitzer
2025-06-23 9:59 ` Mikulas Patocka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ca5ff9e-5e48-4909-7cef-1090c83c882f@redhat.com \
--to=mpatocka@redhat.com \
--cc=bmarzins@redhat.com \
--cc=dm-devel@lists.linux.dev \
--cc=snitzer@kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).