Linux Device Mapper development
 help / color / mirror / Atom feed
From: Xose Vazquez Perez <xose.vazquez@gmail.com>
To: Keith Busch <keith.busch@intel.com>, dm-devel@redhat.com
Subject: Re: [PATCHv2] Fill NVMe specific path info
Date: Wed, 13 Sep 2017 18:14:35 +0200	[thread overview]
Message-ID: <1f1da15e-17eb-b464-0312-93436cf07725@gmail.com> (raw)
In-Reply-To: <1487715151-1179-1-git-send-email-keith.busch@intel.com>

On 02/21/2017 11:12 PM, Keith Busch wrote:

> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> index f5a5f7b..8409261 100644
> --- a/libmultipath/hwtable.c
> +++ b/libmultipath/hwtable.c
> @@ -1073,6 +1073,16 @@ static struct hwentry default_hw[] = {
>  		.prio_name     = PRIO_ALUA,
>  		.no_path_retry = 30,
>  	},
> +	/*
> +	 * Generic NVMe devices
> +	 */
> +	{
> +		.vendor	       = "NVME",
> +		.product       = ".*",
> +		.uid_attribute = "ID_WWN",
> +		.checker_name  = DIRECTIO,
> +		.retain_hwhandler = RETAIN_HWHANDLER_OFF,
> +	},


"NVME" is a too generic regex, could it be replaced by "^NVME" ?

Thanks.

  parent reply	other threads:[~2017-09-13 16:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-21 22:12 [PATCHv2] Fill NVMe specific path info Keith Busch
2017-02-22  0:01 ` Benjamin Marzinski
2017-02-22  1:00 ` Xose Vazquez Perez
2017-09-13 16:14 ` Xose Vazquez Perez [this message]
2018-01-10 16:07 ` Xose Vazquez Perez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1f1da15e-17eb-b464-0312-93436cf07725@gmail.com \
    --to=xose.vazquez@gmail.com \
    --cc=dm-devel@redhat.com \
    --cc=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox