From: Christophe Varoqui <christophe.varoqui@free.fr>
To: device-mapper development <dm-devel@redhat.com>
Subject: Re: [PATCH] multipath-tools: fix minor compilation issues
Date: Mon, 13 Mar 2006 14:50:26 +0100 [thread overview]
Message-ID: <20060313135026.GA6902@pundit> (raw)
In-Reply-To: <4415653C.4050702@suse.de>
On Mon, Mar 13, 2006 at 01:27:40PM +0100, Hannes Reinecke wrote:
> Hi Christophe,
>
> our checker found some minor issues:
>
> - refwwid in libmultipath/configure.c:get_refwwid() might be used
> uninitialized. As dev_type is a simple 'int' there is nothing which
> prevents the unsuspecting user to call it with an unhandled value.
> We shoud rather use an enum and set refwwid to NULL to be on the safe
> side.
> - attr in libmultipath/discovery.c:devt2devname() might be used
> uninitialized. Quite unlikely, but might happen in principle.
> So better have it initialized.
> - r in multipath/main.c:main() might be used uninitialized.
> True. So have it initialized.
>
> Please apply.
>
Applied, thanks.
Regards,
cvaroqui
prev parent reply other threads:[~2006-03-13 13:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-13 12:27 [PATCH] multipath-tools: fix minor compilation issues Hannes Reinecke
2006-03-13 13:50 ` Christophe Varoqui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060313135026.GA6902@pundit \
--to=christophe.varoqui@free.fr \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox