From: Alasdair G Kergon <agk@redhat.com>
To: Nikanth Karthikesan <knikanth@suse.de>
Cc: device-mapper development <dm-devel@redhat.com>
Subject: Re: [PATCH] dm mpath: delay retry activate_path on SCSI_DH_RETRY
Date: Thu, 19 Feb 2009 02:11:18 +0000 [thread overview]
Message-ID: <20090219021118.GA3962@agk.fab.redhat.com> (raw)
In-Reply-To: <200902171917.38252.knikanth@suse.de>
On Tue, Feb 17, 2009 at 07:17:37PM +0530, Nikanth Karthikesan wrote:
> Delay retry to activate_path if it returns SCSI_DH_RETRY.
Please write a complete patch header if you'd like this queued for upstream!
E.g. Why? Any cases where this will make matters worse or make no difference?
> + unsigned long pg_init_jiffy; /* To delay retry if SCSI_DH_RETRY */
> +#define SCSI_DH_RETRY_DELAY ((HZ * 2))
Why that particular value?
Please move it into a header file with an explanation of what it does.
Alasdair
--
agk@redhat.com
next prev parent reply other threads:[~2009-02-19 2:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-17 13:47 [PATCH] dm mpath: delay retry activate_path on SCSI_DH_RETRY Nikanth Karthikesan
2009-02-19 1:55 ` Chandra Seetharaman
2009-02-19 2:11 ` Alasdair G Kergon [this message]
2009-02-19 7:10 ` Nikanth Karthikesan
2009-02-20 0:45 ` Chandra Seetharaman
2009-02-20 5:03 ` Nikanth Karthikesan
2009-02-20 15:08 ` Konrad Rzeszutek
2009-02-20 21:11 ` Chandra Seetharaman
2009-03-02 10:48 ` Nikanth Karthikesan
-- strict thread matches above, loose matches on Subject: below --
2009-04-28 6:15 Nikanth Karthikesan
2009-04-28 19:35 ` Chandra Seetharaman
2009-04-28 22:34 ` Alasdair G Kergon
2009-05-05 3:18 Chandra Seetharaman
2009-05-15 3:10 ` Chandra Seetharaman
2009-05-15 13:38 ` Mike Christie
2009-06-09 20:54 ` Chandra Seetharaman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090219021118.GA3962@agk.fab.redhat.com \
--to=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=knikanth@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).