From: Mike Snitzer <snitzer@redhat.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: device-mapper development <dm-devel@redhat.com>
Subject: Re: dm log: fix create_log_context() to use proper logical_block_size
Date: Wed, 17 Jun 2009 12:29:33 -0400 [thread overview]
Message-ID: <20090617162933.GD638@redhat.com> (raw)
In-Reply-To: <yq14oueq11o.fsf@sermon.lab.mkp.net>
On Wed, Jun 17 2009 at 12:26pm -0400,
Martin K. Petersen <martin.petersen@oracle.com> wrote:
> >>>>> "Mike" == Mike Snitzer <snitzer@redhat.com> writes:
>
> Mike> create_log_context() must use the logical_block_size from the log
> Mike> disk rather than the target's logical_block_size.
>
> Mike> buf_size = dm_round_up((LOG_OFFSET << SECTOR_SHIFT) +
> Mike> bitset_size,
> Mike> - ti->limits.logical_block_size);
> Mike> + q->limits.logical_block_size);
>
> Please use the accessor functions when possible.
>
> bdev_logical_block_size(lc->header_location.bdev) to the rescue....
Ah right, thanks for the reminder!
v2 of the patch to follow...
Mike
prev parent reply other threads:[~2009-06-17 16:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 16:21 [PATCH] dm log: fix create_log_context() to use proper logical_block_size Mike Snitzer
2009-06-17 16:26 ` Martin K. Petersen
2009-06-17 16:29 ` Mike Snitzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090617162933.GD638@redhat.com \
--to=snitzer@redhat.com \
--cc=dm-devel@redhat.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox