From: Mike Snitzer <snitzer@redhat.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: dm-devel@redhat.com
Subject: Re: Snapshot merging
Date: Wed, 9 Sep 2009 11:56:43 -0400 [thread overview]
Message-ID: <20090909155642.GB15981@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0909091142190.2960@hs20-bc2-1.build.redhat.com>
On Wed, Sep 09 2009 at 11:47am -0400,
Mikulas Patocka <mpatocka@redhat.com> wrote:
> Hi
>
> I found one bug in the userspace code --- start merging, then from the
> other console deactivate the origin volume with lvchange -an, then wait
> next 15 seconds for the next poll interval:
>
> the poll process will think that the merging finished, removing the
> snapshot, leaving partially merged origin and causing data corruption:
>
> [slunicko:~]# lvconvert -M vg1/lv2_snap1
> Merging of volume lv2_snap1 started.
> lv2: Merged: 13.1%
> ( .... deactivate the volume from the other console ....)
> lv2: Merged: -1.0%
> Merge into logical volume lv2 finished.
> Logical volume "snapshot4" successfully removed
>
> Maybe this bug was in my code too, I don't remember.
Likely, considering I merely ported your LVM2 patches to the latest
version. That said, I could've introduced this issue by missing
something in the port. Regardless, I'll have a look at preventing the
origin LV from being deactivated during a merge.
> Otherwise, the code seems stable, I didn't see anything wrong, I tried to
> crash it while merging and it resumed without data corruption.
Great, thanks for the feedback and testing!
Mike
next prev parent reply other threads:[~2009-09-09 15:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4A97A035.9010604@redhat.com>
[not found] ` <Pine.LNX.4.64.0908311740160.16318@hs20-bc2-1.build.redhat.com>
[not found] ` <20090831221149.GB15126@redhat.com>
2009-09-09 15:47 ` Snapshot merging Mikulas Patocka
2009-09-09 15:56 ` Mike Snitzer [this message]
2009-09-09 16:12 ` Mike Snitzer
2009-09-09 17:23 ` Mikulas Patocka
2009-09-09 22:06 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090909155642.GB15981@redhat.com \
--to=snitzer@redhat.com \
--cc=dm-devel@redhat.com \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox