From: Mike Snitzer <snitzer@redhat.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: dm-devel@redhat.com, Alasdair G Kergon <agk@redhat.com>,
lvm-devel@redhat.com
Subject: Re: a bug in --namesnapshot merge
Date: Tue, 15 Sep 2009 15:21:13 -0400 [thread overview]
Message-ID: <20090915192113.GA25624@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0909141225570.18131@hs20-bc2-1.build.redhat.com>
On Mon, Sep 14 2009 at 1:21pm -0400,
Mikulas Patocka <mpatocka@redhat.com> wrote:
> Hi
>
> When lvconvert -M --namesnapshot is invoked, there is a bug, it ends up
> with a message like
> device-mapper: snapshots: exception for block 0 is on disk but not in
> memory
>
> The bug is not in the kernel but in the lvm. It loads -real and -cow
> devices badly, so that the kernel treats the origin volume as the
> snapshot.
>
> The --namesnapshot option causes that the snapshot becomes the origin and
> mergin starts, if we have
> lv-origin owi-a- origin
> lv-snapshot swi--- snapshot
> , after lvconvert -M --namesnapshot vg/lv-snapshot, we'll have
> lv-snapshot Owi-a- mergin snapshot, containing the previous content of
> lv-snapshot
>
> The trick that needs to be done is to preserve the logical volume
> structure and the device, but move it from one storage to another. Sadly,
> LVM2 is not designed to do it. That --pivotorigin option that Alasdair
> implemented needed the same trick and it was buggy too.
>
> I'd suggest to remove --namesnapshot option at all (and remove patches
> lvm-merge-swap-uuid.patch and
> lvm-merge-swap-lvid-of-underlying-devices.patch that do most of this
> stuff) and leave only --nameorigin and --onactivate.
>
> The implementation of --namesnapshot is very dirty. I was writing that
> option --namesnapshot for a month, implemented it three times before
> getting it right. And now some other changes to lvm made it nonworking
> again. It is unmaintainable over the long term. It is not worth fixing,
> because it would be beroken again.
>
> Other that that, I think that snapshot merging could be applied to the
> kernel and lvm.
I agree with the above. The two times I rebased those swap uuid patches
they were fairly fragile/subtle/challenging. Eliminating --namesnapshot
seems reasonable. I updated the LVM2 snapshot-merge patches accordingly:
http://people.redhat.com/msnitzer/patches/snapshot-merge/lvm2/LVM2-2.02.52/
prev parent reply other threads:[~2009-09-15 19:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-14 17:21 a bug in --namesnapshot merge Mikulas Patocka
2009-09-15 19:21 ` Mike Snitzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090915192113.GA25624@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=lvm-devel@redhat.com \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox