From: malahal@us.ibm.com
To: dm-devel@redhat.com
Subject: Re: [PATCH 0/2] Add suspended state check for target messages
Date: Fri, 13 Nov 2009 10:30:47 -0800 [thread overview]
Message-ID: <20091113183047.GA19866@us.ibm.com> (raw)
In-Reply-To: <20091113141930.GA3185@agk-dp.fab.redhat.com>
Alasdair G Kergon [agk@redhat.com] wrote:
> Would DMF_BLOCK_IO_FOR_SUSPEND work instead?
Should, provided that multipath_message() and multipath_postsuspend()
use some lock to synchronize. Without the lock, multipath_postsuspend()
could be executed between multipath_message's bit flag check and
its action().
multipath_message()
{
lock();
if (DMF_BLOCK_IO_FOR_SUSPEND is set) {
unlock and fail;
} else { /* postsuspend has not been executed yet and won't be
completed until we are done here */
action();
}
unlock();
}
multipath_postsuspend()
{
lock();
flush work();
unlock();
}
next prev parent reply other threads:[~2009-11-13 18:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-13 8:06 [PATCH 0/2] Add suspended state check for target messages Mike Anderson
2009-11-13 8:06 ` [PATCH 1/2] dm: Add accessor dm_table_md_suspended Mike Anderson
2009-11-13 14:19 ` Mike Snitzer
2009-11-13 8:06 ` [PATCH 2/2] dm: Add suspended check to multipath_message Mike Anderson
2009-11-13 18:35 ` malahal
2009-11-13 10:22 ` [PATCH 0/2] Add suspended state check for target messages Kiyoshi Ueda
2009-11-13 14:19 ` Alasdair G Kergon
2009-11-13 18:30 ` malahal [this message]
2009-11-13 18:47 ` Mike Anderson
2009-11-16 7:25 ` Kiyoshi Ueda
2009-11-16 7:43 ` Mike Anderson
2009-11-16 13:23 ` Alasdair G Kergon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091113183047.GA19866@us.ibm.com \
--to=malahal@us.ibm.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox