dm-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: neilb@suse.de
To: dm-devel@redhat.com
Subject: [dmraid 4/4] Fix two issues with installing shared libraries.
Date: Thu, 17 Dec 2009 16:44:14 +1100	[thread overview]
Message-ID: <20091217054532.073566335@suse.de> (raw)
In-Reply-To: 20091217054410.410634166@suse.de

[-- Attachment #1: lib-install --]
[-- Type: text/plain, Size: 1194 bytes --]

1/  the [[ =~ ]] operator only treats the RHS as a regular expression
   if it isn't quoted.  So we need to remove the quotes.

2/ The libdmraid-event-* library is not a shared library in the regular
   sense.  i.e. programs are not linked against it and so do not have the
   library version number encoded in them.
   Rather, this is a shared-object that is explicitly loaded by dmeventd
   on request from dmraid.  dmraid asks for "libdmraid-event-ism.so", so
   that is the only name that the shared object should be stored under.
   Providing a name with a trailing version number just makes it look like
   something that it is not.

Signed-off-by: NeilBrown <neilb@suse.de>
---
 lib/Makefile.in |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- dmraid.orig/lib/Makefile.in
+++ dmraid/lib/Makefile.in
@@ -82,7 +82,7 @@ install_dmraid_libs: $(INSTALL_TARGETS)
 	for f in $(INSTALL_TARGETS); \
 	do \
 		n=$$(basename $${f}) ; \
-		if [[ "$$n" =~ '.so$$' ]]; then \
+		if [[ "$$n" =~ .so$$ && ! "$$n" =~ libdmraid-events-.* ]]; then \
 			$(INSTALL) -m 555 $(STRIP) \
 				$$f $(libdir)/$${n}.@DMRAID_LIB_VERSION@; \
 			$(LN_S) -f $${n}.@DMRAID_LIB_VERSION@ $(libdir)/$${n}; \

      parent reply	other threads:[~2009-12-17  5:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-17  5:44 [dmraid 0/4] A few patches for dmraid neilb
2009-12-17  5:44 ` [dmraid 1/4] Parse "-cc" as required by man page neilb
2009-12-17 16:50   ` Heinz Mauelshagen
2009-12-17  5:44 ` [dmraid 2/4] Avoid fd leak in remove_device_partitions neilb
2009-12-17  5:44 ` [dmraid 3/4] Fix min/max macros neilb
2009-12-17  5:44 ` neilb [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091217054532.073566335@suse.de \
    --to=neilb@suse.de \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).