From: Alasdair G Kergon <agk@redhat.com>
To: "Justin P. Mattock" <justinmattock@gmail.com>
Cc: dm-devel@redhat.com, neilb@suse.de, agk@redhat.com,
linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]md:dm.c Fix warning: statement with no effect
Date: Sat, 31 Jul 2010 20:07:57 +0100 [thread overview]
Message-ID: <20100731190757.GC9734@agk-dp.fab.redhat.com> (raw)
In-Reply-To: <4C5473E0.308@gmail.com>
On Sat, Jul 31, 2010 at 12:05:04PM -0700, Justin P. Mattock wrote:
> haven't heard any feedback on this any ideas?
>> Ive noticed that having CONFIG_BLK_DEV_INTEGRITY=n I get warning messages generated by GCC(below)
>> CC drivers/md/dm.o
>> drivers/md/dm.c: In function 'split_bvec':
>> drivers/md/dm.c:1117:3: warning: statement with no effect
>> drivers/md/dm.c: In function 'clone_bio':
>> drivers/md/dm.c:1145:3: warning: statement with no effect
I'd suggest hiding it inside the .h files and not trying to scatter #ifdefs
throughout the code.
Alasdair
next prev parent reply other threads:[~2010-07-31 19:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-13 1:26 [PATCH]md:dm.c Fix warning: statement with no effect Justin P. Mattock
2010-07-31 19:05 ` Justin P. Mattock
2010-07-31 19:07 ` Alasdair G Kergon [this message]
2010-07-31 19:13 ` Justin P. Mattock
2010-08-01 22:23 ` Justin P. Mattock
2011-01-11 21:22 ` Mike Snitzer
2011-01-12 1:26 ` Justin Mattock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100731190757.GC9734@agk-dp.fab.redhat.com \
--to=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=justinmattock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).