From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alasdair G Kergon Subject: Re: [PATCH]md:dm.c Fix warning: statement with no effect Date: Sat, 31 Jul 2010 20:07:57 +0100 Message-ID: <20100731190757.GC9734@agk-dp.fab.redhat.com> References: <1278984400-8837-1-git-send-email-justinmattock@gmail.com> <4C5473E0.308@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4C5473E0.308@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: "Justin P. Mattock" Cc: dm-devel@redhat.com, neilb@suse.de, agk@redhat.com, linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: dm-devel.ids On Sat, Jul 31, 2010 at 12:05:04PM -0700, Justin P. Mattock wrote: > haven't heard any feedback on this any ideas? >> Ive noticed that having CONFIG_BLK_DEV_INTEGRITY=n I get warning messages generated by GCC(below) >> CC drivers/md/dm.o >> drivers/md/dm.c: In function 'split_bvec': >> drivers/md/dm.c:1117:3: warning: statement with no effect >> drivers/md/dm.c: In function 'clone_bio': >> drivers/md/dm.c:1145:3: warning: statement with no effect I'd suggest hiding it inside the .h files and not trying to scatter #ifdefs throughout the code. Alasdair