dm-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Benjamin Marzinski <bmarzins@redhat.com>
To: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
Cc: Kiyoshi Ueda <k-ueda@ct.jp.nec.com>,
	device-mapper development <dm-devel@redhat.com>,
	Michael Christie <mchristi@redhat.com>
Subject: Re: [PATCH] multipath: add fast_io_fail and	dev_loss_tmo config parameters
Date: Tue, 3 Aug 2010 13:15:27 -0500	[thread overview]
Message-ID: <20100803181527.GK25030@ether.msp.redhat.com> (raw)
In-Reply-To: <4C5297AA.4070708@ce.jp.nec.com>

On Fri, Jul 30, 2010 at 06:13:14PM +0900, Jun'ichi Nomura wrote:
> Hi,
> 
> (03/23/10 11:44), Benjamin Marzinski wrote:
> > This patch adds two new configuration parameters to multipath.conf,
> > fast_io_fail_tmo and dev_loss_tmo which set
> > 
> > /sys/class/fc_remote_ports/rport-<host>:<channel>-<rport_id>/fast_io_fail_tmo and
> > /sys/class/fc_remote_ports/rport-<host>:<channel>-<rport_id>/dev_loss_tmo
> ...
> 
> This is nice feature but the code uses scsi_id instead of rport_id:
> 

Indeed it does. Sorry.

You patch looks fine to me.

-Ben

  parent reply	other threads:[~2010-08-03 18:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-30  9:13 [PATCH] multipath: add fast_io_fail and dev_loss_tmo config parameters Jun'ichi Nomura
2010-08-03  1:18 ` Jun'ichi Nomura
2010-08-03 18:15 ` Benjamin Marzinski [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-03-23  2:44 Benjamin Marzinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100803181527.GK25030@ether.msp.redhat.com \
    --to=bmarzins@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=j-nomura@ce.jp.nec.com \
    --cc=k-ueda@ct.jp.nec.com \
    --cc=mchristi@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).