From: Mike Snitzer <snitzer@redhat.com>
To: dm-devel@redhat.com
Subject: [PATCH] dm: use revalidate_disk to update device size after set_capacity
Date: Tue, 19 Oct 2010 18:07:11 -0400 [thread overview]
Message-ID: <20101019220711.GA25169@redhat.com> (raw)
Avoid taking md->bdev->bd_inode->i_mutex to update the DM block device's
size. Doing so eliminates the potential for deadlock if an fsync is
racing with a device resize.
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
---
drivers/md/dm.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index f934e98..fd315a7 100644
--- a/drivers/md/dm.c
+++ b/drivers/md/dm.c
@@ -1995,10 +1995,7 @@ static void event_callback(void *context)
static void __set_size(struct mapped_device *md, sector_t size)
{
set_capacity(md->disk, size);
-
- mutex_lock(&md->bdev->bd_inode->i_mutex);
- i_size_write(md->bdev->bd_inode, (loff_t)size << SECTOR_SHIFT);
- mutex_unlock(&md->bdev->bd_inode->i_mutex);
+ revalidate_disk(md->disk);
}
/*
next reply other threads:[~2010-10-19 22:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 22:07 Mike Snitzer [this message]
2010-10-20 5:42 ` [PATCH] dm: use revalidate_disk to update device size after set_capacity Jun'ichi Nomura
2010-10-28 1:16 ` Mike Snitzer
2010-10-28 12:15 ` Jun'ichi Nomura
2010-10-28 19:54 ` Mike Snitzer
2010-10-28 22:18 ` Mike Snitzer
2010-10-29 3:00 ` Jun'ichi Nomura
2010-10-29 21:50 ` dm: lock bd_mutex when setting device size Mike Snitzer
2010-11-01 7:19 ` Jun'ichi Nomura
2010-11-01 13:14 ` Mike Snitzer
2010-11-03 18:06 ` [PATCH] dm: remove extra locking when changing " Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019220711.GA25169@redhat.com \
--to=snitzer@redhat.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).