* [PATCH] imported patch sync-no_cluster-with-cluster-flag.patch
@ 2010-08-29 17:59 Malahal Naineni
2010-08-29 20:31 ` [PATCH] block: QUEUE_FLAG_CLUSTER and no_cluster are NOT in sync Malahal Naineni
0 siblings, 1 reply; 3+ messages in thread
From: Malahal Naineni @ 2010-08-29 17:59 UTC (permalink / raw)
To: jaxboe, dm-devel
diff -r 8305d08f6ecf -r 5e7598cf7714 drivers/scsi/scsi_lib.c
--- a/drivers/scsi/scsi_lib.c Wed Aug 25 13:44:33 2010 -0700
+++ b/drivers/scsi/scsi_lib.c Wed Aug 25 13:44:33 2010 -0700
@@ -1633,8 +1633,10 @@ struct request_queue *__scsi_alloc_queue
blk_queue_max_segment_size(q, dma_get_max_seg_size(dev));
/* New queue, no concurrency on queue_flags */
- if (!shost->use_clustering)
+ if (!shost->use_clustering) {
queue_flag_clear_unlocked(QUEUE_FLAG_CLUSTER, q);
+ q->limits.no_cluster = 1;
+ }
/*
* set a reasonable default alignment on word boundaries: the
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] block: QUEUE_FLAG_CLUSTER and no_cluster are NOT in sync
2010-08-29 17:59 [PATCH] imported patch sync-no_cluster-with-cluster-flag.patch Malahal Naineni
@ 2010-08-29 20:31 ` Malahal Naineni
2010-11-02 20:21 ` Mike Snitzer
0 siblings, 1 reply; 3+ messages in thread
From: Malahal Naineni @ 2010-08-29 20:31 UTC (permalink / raw)
To: jaxboe, dm-devel
Here is the missing header:
no_cluster is used by device mapper (may be others) resulting in
multipath devices setting QUEUE_FLAG_CLUSTER flag even though the
underlying devices (e.g. open iscsi virtual adapter) don't support it.
Signed-off-by: Malahal Naineni (malahal@us.ibm.com)
Malahal Naineni [malahal@us.ibm.com] wrote:
> diff -r 8305d08f6ecf -r 5e7598cf7714 drivers/scsi/scsi_lib.c
> --- a/drivers/scsi/scsi_lib.c Wed Aug 25 13:44:33 2010 -0700
> +++ b/drivers/scsi/scsi_lib.c Wed Aug 25 13:44:33 2010 -0700
> @@ -1633,8 +1633,10 @@ struct request_queue *__scsi_alloc_queue
> blk_queue_max_segment_size(q, dma_get_max_seg_size(dev));
>
> /* New queue, no concurrency on queue_flags */
> - if (!shost->use_clustering)
> + if (!shost->use_clustering) {
> queue_flag_clear_unlocked(QUEUE_FLAG_CLUSTER, q);
> + q->limits.no_cluster = 1;
> + }
>
> /*
> * set a reasonable default alignment on word boundaries: the
>
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: block: QUEUE_FLAG_CLUSTER and no_cluster are NOT in sync
2010-08-29 20:31 ` [PATCH] block: QUEUE_FLAG_CLUSTER and no_cluster are NOT in sync Malahal Naineni
@ 2010-11-02 20:21 ` Mike Snitzer
0 siblings, 0 replies; 3+ messages in thread
From: Mike Snitzer @ 2010-11-02 20:21 UTC (permalink / raw)
To: Malahal Naineni; +Cc: linux-scsi, jaxboe, dm-devel
Malahal,
This patch should go through the scsi tree. Please update the patch (so
it includes the patch header) and repost to linux-scsi.
Thanks,
Mike
On Sun, Aug 29 2010 at 4:31pm -0400,
Malahal Naineni <malahal@us.ibm.com> wrote:
> Here is the missing header:
>
> no_cluster is used by device mapper (may be others) resulting in
> multipath devices setting QUEUE_FLAG_CLUSTER flag even though the
> underlying devices (e.g. open iscsi virtual adapter) don't support it.
>
> Signed-off-by: Malahal Naineni (malahal@us.ibm.com)
>
> Malahal Naineni [malahal@us.ibm.com] wrote:
> > diff -r 8305d08f6ecf -r 5e7598cf7714 drivers/scsi/scsi_lib.c
> > --- a/drivers/scsi/scsi_lib.c Wed Aug 25 13:44:33 2010 -0700
> > +++ b/drivers/scsi/scsi_lib.c Wed Aug 25 13:44:33 2010 -0700
> > @@ -1633,8 +1633,10 @@ struct request_queue *__scsi_alloc_queue
> > blk_queue_max_segment_size(q, dma_get_max_seg_size(dev));
> >
> > /* New queue, no concurrency on queue_flags */
> > - if (!shost->use_clustering)
> > + if (!shost->use_clustering) {
> > queue_flag_clear_unlocked(QUEUE_FLAG_CLUSTER, q);
> > + q->limits.no_cluster = 1;
> > + }
> >
> > /*
> > * set a reasonable default alignment on word boundaries: the
> >
> > --
> > dm-devel mailing list
> > dm-devel@redhat.com
> > https://www.redhat.com/mailman/listinfo/dm-devel
>
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-11-02 20:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-29 17:59 [PATCH] imported patch sync-no_cluster-with-cluster-flag.patch Malahal Naineni
2010-08-29 20:31 ` [PATCH] block: QUEUE_FLAG_CLUSTER and no_cluster are NOT in sync Malahal Naineni
2010-11-02 20:21 ` Mike Snitzer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).